txchen / feplay

Frontend Play

• 👋 Hi, I’m @txchen
• 👀 I’m interested in ...
• 🌱 I’m currently learning ...
• 💞️ I’m looking to collaborate on ...
• 📫 How to reach me ...

feplay's Issues

Webpack Async Example Error

riotjs-loader works fine the in the example without async, but in async throws:

ERROR in ./src/view/detail-view.html Module build failed: Error: TypeError: unknown: resolveModuleSource is not a function at Object.module.exports (/Users/gnb/Sites/Playground/feplay/riot_webpack_async/node_modules/riotjs-loader/index.js:32:11) @ ./src/riotTags.js 9:0-34

riot_vue, gridcomponent is not working correctly

Sort table is not working, due to riot/riot#302

Wait until riot fixes it and verify this example.

Perceivable lag when typing into input/textarea

The Markdown Editor and Grid Component demos in riot_vue exhibit perceivable input lag. This is because they listen to keyup event which fires late. To match the behavior of the Vue implementation, I suggest using to the input event.

TL;DR: change onkeyup to oninput in <input> and <textarea> tags.

Disable callbacks when unmounting tags

Hello, @txchen ! And thanks for the great code example!

I'm using your riot_webpack as a base to one project. It is a great help!

But today I saw that everytime I do in a tag:

riot.control.on(signal, func)

I need to also do:

this.on('unmount', () => riot.control.off(signal, func))

If not, when the tag is mounted again, the old callback will still be there, so func will be run 2X. Here, after some remounts the callback would be running +30X.
I tested your code now, and it seems to have the same problem.

Am I misunderstanding something?

Here the problem was fixed by adding this to a base mixing (used by all tags):

    onControl: function(signal, func) {
        riot.control.on(signal, func)
        this.on('unmount', () => riot.control.off(signal, func))
    },

And calling it instead of riot.control.on.

Update riot_vue

Vuejs hit 1.0. And it now has some new examples, convert them to riot.

TodoMVC, routing is not working

Because riot's bug, string literal cannot be used in expression. Wait until riot fix it.

Link to tacit stylesheet is broken

I found it in http://yegor256.github.io/tacit/tacit.min.css

Post to tastejs/todomvc

I think this Riot 2.0 example should be posted to the official Todo MVC repository. They are not too open to new suggestions so I suggest to read the contributing document very closely.

Here is a very interesting discussion why we were rejected last time.

Willing to take a shot?

你是**人吗，一起交流下，我也在研究 riot.js

看了你的代码，觉得不错，有机会一起交流交流
这是我最近做的库，互相 star