twenzel / cgm

Converts, imports and exports CGM graphics

Hi, I'm Toni 👋

Find me elsewhere

• Tweeting my thoughts
• Professional profile
• Do some side projects for customers

cgm's Issues

PolygonSet command's parsing order

PolygonSet's ReadFromBinary method first reads edgeOutFlag then reads points. According to ISO 8632-1 (page 164), it should be the other way around. Could not create a pull request due to permissions.

Btw, great work, thanks for all the effort!

ClearText CGM of CGM that contains an Image is not correctly converted

Hi,

I was using your software to convert some CGMs to clear text, but I have some issues with the CGMs that contain an embedded image inside.
See below an example:
CGM2clearText.zip

The _clearText cgm appears to be converted to clear text, but when I open it this is what I see:

ColourTable.GetColor method index calculation problem

ColourTable's GetColor method adds the StartIndex to the given argument index. It causes ArgumentOutOfIndex exception. Shouldn't it be a subtraction?

Exception on loading BITONALTILE

On loading a binary WebCGM which contains a BITONALTILE in a BEGTILEARRAY the library throws an exception Error on EnsureAllArgumentsWereRead in BitonalTile command for file 'xx'!

The total size of the file is 9.144 Bytes, so I assume that the file size is not the issue.

The Stacktrace is listed below:
at codessentials.CGM.Commands.Command.Assert(Boolean isCorrect, String errorMessage) in C:\Users\teuchert_d\source\github\CGM\src\Commands\Command.cs:line 282 at codessentials.CGM.Import.DefaultBinaryReader.EnsureAllArgumentsWereRead() in C:\Users\teuchert_d\source\github\CGM\src\Import\DefaultBinaryReader.cs:line 227 at codessentials.CGM.Import.DefaultBinaryReader.ReadCommand() in C:\Users\teuchert_d\source\github\CGM\src\Import\DefaultBinaryReader.cs:line 343 at codessentials.CGM.Import.DefaultBinaryReader.ReadCommands() in C:\Users\teuchert_d\source\github\CGM\src\Import\DefaultBinaryReader.cs:line 64 at codessentials.CGM.BinaryCgmFile.ReadData(Stream stream) in C:\Users\teuchert_d\source\github\CGM\src\BinaryCGMFile.cs:line 98 at codessentials.CGM.BinaryCgmFile.ReadData(String fileName) in C:\Users\teuchert_d\source\github\CGM\src\BinaryCGMFile.cs:line 106 at codessentials.CGM.BinaryCgmFile..ctor(String fileName) in C:\Users\teuchert_d\source\github\CGM\src\BinaryCGMFile.cs:line 32 at CgmReader.Services.CgmReader.ConvertBinaryToTextCgmFile(String filePath, Boolean storeFile) in C:\Users\teuchert_d\source\CgmReader\CgmReader.Core\Services\CgmReader.cs:line 21 at CgmReader.Program.Main(String[] args) in C:\Users\teuchert_d\source\CgmReader\CgmReader\Program.cs:line 44