twaddington / django-gravatar Goto Github PK

During creating test database I get:

SystemCheckError: System check identified some issues:
 
ERRORS:
 ?: (admin.E404) 'django.contrib.messages.context_processors.messages' must be enabled in DjangoTemplates (TEMPLATES) in order to use the admin application.
 
System check identified 1 issue (0 silenced).

Doing what the error message suggests fixes the issue for me. Hence I am not familiar with the code sufficiently in my opinion, I do not dare to make a PR. I can do on demand, though.

having a size defined causes the hash to be incorrect.

After update to 1.9 tag {% gravatar email %} return following code:
<img class="gravatar" src="https://secure.gravatar.com…" />

There are services that generate "default" user icons based on their name, email, etc. The current GRAVATAR_DEFAULT_IMAGE setting cannot use these services.

I propose two things:

1. The gravatar template tag be changed to accept a "default image URL" argument.
2. The GRAVATAR_DEFAULT_IMAGE be changed to accept either a string (the current behavior), or a callable which will be called with the tag's parameters and will return a URL for the fallback image. That way, we can specify a function that will accept email/size/etc and will return a URL for the default image for the user.

Retina js - http://imulus.github.io/retinajs/

Hi! I'm packaging django-gravatar for Arch Linux.
We usually use pypi for tracking new versions and building from sources.

However, when building 1.4.2 I realized, that the test application is missing from the sdist on pypi.
It would be very awesome, if it could be added. Thank you!

Hey,

First, thanks for your work!

As gravatar is a proprietary, centralized solution, there is a free, decentralized alternative called libravatar. I don't know how hard it would be to provide also support for it, but as libravatar fallbacks on gravatar when nothing is found, so it could offer a wider compatibility to your library.

Would you be interested in?

https://www.libravatar.org/

Cheers !

PEB

It will be great if function has_gravatar() send short HEAD-request instead of GET-request...

In order to get an image with quality for highres screens (like 2k, 4k or retina) you have to load the image with double size and display it in actual size. That could be a setting.

For example: when using {% gravatar user.email 100 %} you would have to load the gravatar image with 200 and than set width and height to 100 on the HTML or CSS.

Hi! 👋

I package this project for Arch Linux.
We have started to no longer rely on sdist tarballs hosted on PyPI due to various issues (https://rfc.archlinux.page/0020-sources-for-python-packaging/) and are switching all packages to either git sources or upstream provided, auto-generated tarballs.

While doing so, I noticed that the 1.4.4 release is not tagged in this repository.
Maybe you forgot to push the tag?
Either way: It would be much appreciated if you could add a tag for that particular version. 🙏

{% gravatar_url request.user.email 250 %} return this

'https://secure.gravatar.com/avatar/936c6f79aabd47f7b205fbe6c498b836.jpg?s=250&r=g&d=https%3A%2F%2Fjumpch.at%2Fstatic%2Fimg%2Fdefault-avatar.png'

The & should have not be escaped. It should look like the following.

'https://secure.gravatar.com/avatar/936c6f79aabd47f7b205fbe6c498b836.jpg?s=250&r=g&d=https%3A%2F%2Fjumpch.at%2Fstatic%2Fimg%2Fdefault-avatar.png'

If I try to install django-gravatar2 I get the following:

$ pip install django-gravatar2
Downloading/unpacking django-gravatar2
  Downloading django-gravatar2-1.0.3.tar.gz
  Running setup.py egg_info for package django-gravatar2
    Traceback (most recent call last):
      File "<string>", line 14, in <module>
      File ".../django-gravatar2/setup.py", line 3, in <module>
        readme = open('README.rst')
    IOError: [Errno 2] No such file or directory: 'README.rst'
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 14, in <module>

  File ".../build/django-gravatar2/setup.py", line 3, in <module>

    readme = open('README.rst')

IOError: [Errno 2] No such file or directory: 'README.rst'

I supposed this is because the latest release (1.0.3) has been generated/uploaded using a python that hadn't access to setuptools-git. Can you please re-release it on pypi (just make sure you have setuptools-git installed and rerun python setup.py upload)?

Note: older versions (e.g. 1.0.1) work fine

By providing the example_project as a top-level module, it conflicts with other projects (e.g. hyperkitty).

If it should be installed, it needs to go below the django-gravatar namespace and can not live top-level in site-packages.