tvelocity / dockerfiles Goto Github PK

This is a popular request, e.g. in #36 where an implementation was proposed

Hi,
Thanks to share your work ;-)

In entrypoint.sh when talking to mysql, around line 35, there is -hmysql but it should be -h mysql.

Cheers.

With a simple apt update && apt upgrade && apt install abiword installation, without the XDG environment variable, I got a working abiword import/export feature for HTML, PDF and Microsoft Word (ie, all formats excepted LibreOffice).

Did you get another issue at commit 5b6d8a6e21f7 "Remove abiword and base on debian jessie image" or was it only for OpenOffice?

If so, perhaps a good idea could be to offer all the others conversions but disable the OpenOffice one from the UI:

diff --git a/src/templates/pad.html b/src/templates/pad.html
index 9a9c6f0..809e6e5 100644
--- a/src/templates/pad.html
+++ b/src/templates/pad.html
@@ -234,7 +234,6 @@
                 <a id="exportplaina" target="_blank" class="exportlink"><div class="exporttype" id="exportplain" data-l10n-id="pad.importExport.exportplain"></div></a>
                 <a id="exportworda" target="_blank" class="exportlink"><div class="exporttype" id="exportword" data-l10n-id="pad.importExport.exportword"></div></a>
                 <a id="exportpdfa" target="_blank" class="exportlink"><div class="exporttype" id="exportpdf" data-l10n-id="pad.importExport.exportpdf"></div></a>
-                <a id="exportopena" target="_blank" class="exportlink"><div class="exporttype" id="exportopen" data-l10n-id="pad.importExport.exportopen"></div></a>
                 <% e.end_block(); %>
             </div>
         </div>
diff --git a/src/templates/timeslider.html b/src/templates/timeslider.html
index 395d0c4..172c975 100644
--- a/src/templates/timeslider.html
+++ b/src/templates/timeslider.html
@@ -216,7 +216,6 @@
   <a id="exportplaina" target="_blank" class="exportlink"><div class="exporttype" id="exportplain" data-l10n-id="pad.importExport.exportplain"></div></a>
   <a id="exportworda" target="_blank" class="exportlink"><div class="exporttype" id="exportword" data-l10n-id="pad.importExport.exportword"></div></a>
   <a id="exportpdfa" target="_blank" class="exportlink"><div class="exporttype" id="exportpdf" data-l10n-id="pad.importExport.exportpdf"></div></a>
-  <a id="exportopena" target="_blank" class="exportlink"><div class="exporttype" id="exportopen" data-l10n-id="pad.importExport.exportopen"></div></a>
 </div>
 </div>

Currently, the quickstart instructions in README.md offers to launch a MySQL container, and to link it to the Etherpad container:

$ docker run -d -e MYSQL_ROOT_PASSWORD=password --name ep_mysql mysql
$ docker run -d --link=ep_mysql:mysql -p 9001:9001 tvelocity/etherpad-lite

Then, the container populates the database and generates a settings.json file.

It gets according entrypoint.sh the MySQL host using this environment variable provided by Docker:
ETHERPAD_DB_HOST="${MYSQL_PORT_3306_TCP_ADDR}"

Yet, to know this environment variable contains the IP address of our MySQL server, we must know it's called mysql (these variables follows the convention <name>_PORT_<port>_<protocol> according https://docs.docker.com/userguide/dockerlinks/#environment-variables

So, it would be more straightforward to use ETHERPAD_DB_HOST=mysql than to query the IP address matching the mysql container.

As an additional benefit, if the Docker network configuration is modified, the connection will still work, which is not currently the case.

Would love this support so I can run on any port.

I have been using the "tvelocity/etherpad-lite" container for a while now. But when I tried to set it up on a new mashine, I noticed that the "Quickstart" guide does not work any more.

Doing the following
$ docker network create ep_network
$ docker run -d --network ep_network -e MYSQL_ROOT_PASSWORD=password --name ep_mysql mysql
$ docker run -d --network ep_network -e ETHERPAD_DB_HOST=ep_mysql -e ETHERPAD_DB_PASSWORD=password -p 9001:9001 tvelocity/etherpad-lite
results in a crashing etherpad container.

When you strap the -d, you see the following error message:
ERROR 2059 (HY000): Authentication plugin 'caching_sha2_password' cannot be loaded: /usr/lib/mysql/plugin/caching_sha2_password.so: cannot open shared object file: No such file or directory
Looking this up online reveals that this problem has been introduced with the switch from MySQL 5.7 to 8.0 in April 2018. Since no version was specified in the command given in the Quickstart, "latest" is assumed.

A working quickfix is to specify the compatible MySQL version instead:
$ docker run -d --network ep_network -e MYSQL_ROOT_PASSWORD=password --name ep_mysql mysql:5.7

Is it possible to make this compatible with a volume mounted sqlite database or instead to PostgreSQL?

I noticed that the mySQL DB contains a table "store" but it's empty. If I restart the containers, all pads are lost.

Does anyone know the reason?

Obviously the DB connection needs to work because the store table is created. I cannot see any error messages in the docker logs (but I see the flush messages)...

Hi,

I usually run web services under port 80. Do you think we could maybe use an env variable for that?

Thanks!

Piere

This is a deprecated method more or less and it seems difficult to make this image work with docker networks, because of https://github.com/tvelocity/dockerfiles/blob/master/etherpad-lite/entrypoint.sh#L4

See https://docs.docker.com/engine/userguide/networking/

https://github.com/tvelocity/dockerfiles/blob/master/etherpad-lite/entrypoint.sh#L41 is incorrect

See https://github.com/ether/etherpad-lite/wiki/How-to-use-Etherpad-Lite-with-MySQL

Patch landing now.

There was an error processing your settings.json file: Unexpected string

is what you get when starting with, e.g.

docker run -d \
    --network ep_network \
    -e ETHERPAD_TITLE="The \"Etherpad" \
    -e ETHERPAD_DB_HOST=ep_mysql \
    -e ETHERPAD_DB_PASSWORD=password \
    -p 9001:9001 \
    tvelocity/etherpad-lite

A simple workaround is to double escape the quotes, however isn't yet documented and feels unintuitive. #19 has code delegating JSON formatting to nodejs. Attempting to JSON-encode in bash directly isn't working that well.

Additionally an extra comma is left in some situations right after the dbSettings, which isn't allowed by the JSON specification (etherpad works with them).

docker run -d -e MYSQL_ROOT_PASSWORD=password --name ep_mysql mysql
sudo docker run -d --link=ep_mysql:mysql -p 9001:9001 tvelocity/etherpad-lite

docker run -d -e MYSQL_ROOT_PASSWORD=password --name ep_mysql2 mysql
sudo docker run -d --link=ep_mysql2:mysql -p 9002:9002 tvelocity/etherpad-lite

0b23dab5e2b35a9b75dd0158d9567e7faed817cbada5c3de9182d3edef08b587
2015/04/23 16:24:44 Error response from daemon: Cannot start container 0b23dab5e2b35a9b75dd0158d9567e7faed817cbada5c3de9182d3edef08b587: Bind for 0.0.0.0:9002 failed: port is already allocated

However nothing is appearing on port 9002

This makes me think the port isn't being properly passed to Etherpad?

Any idea?

Cannot get the latest version of this Docker image to run. I used to run an older version just fine.

If I run docker logs etherpad, I see this:

Ensure that all dependencies are up to date...  If this is the first time you have run Etherpad please be patient.
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No repository field.
Ensure jQuery is downloaded and up to date...
Clearing minified cache...
Ensure custom css/js files are created...
Started Etherpad...
[2018-04-29 05:06:20.903] [ERROR] console - ERROR: npm is known not to run on Node.js v0.10.29
[2018-04-29 05:06:20.905] [ERROR] console - You'll need to upgrade to a newer version in order to use this
[2018-04-29 05:06:20.905] [ERROR] console - version of npm. Supported versions are 6, 8, 9, 10. You can find the
[2018-04-29 05:06:20.905] [ERROR] console - latest version at https://nodejs.org/

Etherpad application creates APIKEY.txt from the random string if it is missing.

This leads to etherpad instances randomly changing API keys when stack is recreated (e.g. due to rebuild).

It would be idiomatic to allow configuration via environment variables, and also let users know they could bind-mount the file if they want consistent API access.

Hi,

what's the point of having settings.json in a volume? How can I access it from outside the container?

For me it seems, the file is recreated every time a new container is run (eg. after reboot).

Currently, a volume is provided by Dockerfile to store settings.json, but this file is overwritten at container restart.

entrypoint.sh should only generate it if missing.