Simplification of screen areas about tuxemon

[ShadowApex]

I think this is a great idea. To let you know, I've previously done work on trying to refactor the menu system to make it easier to use in the "menu_refactor" branch. It's been a while since I've worked on it, so merging it to development might be painful, but I'd like to incorporate some of its functionality into the menus.

You can take a look at the refactored menu I've been working on here: https://github.com/Tuxemon/Tuxemon/blob/menu_refactor/tuxemon/core/components/menu/__init__.py#L50

[bitcraft]

I can merge that into my branch. Looks like there was a lot of effort put
into it. It would help me if you could make a small list of the overall
changes that need to be migrated. From just a quick look, it seems that the
complicated parts have been broken down functions. Thanks!

Overall, my goal for the menu refactor has been to break down some parts
to make them fit the State API. I don't want to re implement them, just
move enough code around that it works.

On Wed, Dec 30, 2015 at 12:14 AM William Edwards [email protected]
wrote:

I think this is a great idea. To let you know, I've previously done work
on trying to refactor the menu system to make it easier to use in the
"menu_refactor" branch. It's been a while since I've worked on it, so
merging it to development might be painful, but I'd like to incorporate
some of its functionality into the menus.

You can take a look at the refactored menu I've been working on here:
https://github.com/Tuxemon/Tuxemon/blob/menu_refactor/tuxemon/core/components/menu/__init__.py#L50

—
Reply to this email directly or view it on GitHub
#85 (comment).

[ShadowApex]

Yeah, the refactor removed a lot of unnecessary legacy bits and added a lot of helper methods to remove a lot of the code duplication seen throughout the codebase.

Here's a quick summary of the things I had done:

• Removed unnecessary parameters like screen, resolution, etc.
• Added init params to construct menus with their size and position upon creation.
• Made the menu inherit from the UserInterface class to provide functionality like moving over time and playing background and menu border animations.
• Added next, previous, and done to make menus more state-like. These will probably be deprecated with your changes.
• Broke up some methods into smaller functions for easier reuse and readability.
• Added helper methods like menu_select_next, menu_select_prev, set_size, and set_position.
• Made drawing dependent on the self.visible property.
• Made input handling dependent on the self.interactable property.
• Replaced methods like draw, draw_text, and draw_textItem with a single draw() method.
• Text drawing is done automatically in draw after you call set_text once instead of needing to pass the text to draw every frame.

[bitcraft]

Thanks for the write up. Details like how text drawing will help make sure there are no regressions.

[bitcraft]

I'm going to close this. My current branch has changes the "pos_x", "size_x", etc variables into pygame Rects. Updates to the states/menu refactor will be in #72.