turbonomic / turbo-go-sdk

turbo-go-sdk

turbo-go-sdk's Issues

switch to another gorilla/websocket package

According to the golang official statement,
This package(golang.org/x/net/websocket) currently lacks some features found in an alternative and more actively maintained WebSocket package: https://godoc.org/github.com/gorilla/websocket

The drawbacks of x/net/websocket are:

• Less actively maintained;
• Lack some features: especially the ping-pong protocol(RFC 6455), which is essential for keeping alive check.

Go SDK needs to enforce minima for discovery intervals and default for full discovery

The Java SDK now enforces the following discovery intervals when it parses the probe-conf.xml file:
Full Discovery (rediscovery-interval-seconds) must be >= 60. Also, if no rediscovery-interval-seconds is specified in the xml, use default value of 600 seconds.
Performance Discovery (performance-rediscovery-interval-seconds) - if specified, must be >=60. If not specified the ProbeInfo should return -1 for getPerformanceRediscoveryIntervalSeconds().
Incremental Discovery (incremental-rediscovery-interval-seconds) - if specified, must be >=1. If not specified the ProbeInfo should return -1 for getIncrementalRediscoveryIntervalSeconds().

including the original protobuf for easier comparison

It is important to know the changes of the canonical protobuf definition from sdk team.
Currently, only the generated go code of the protobuf is included in this repos. To know what has been changed, we have to checkout the protobuf definition from sdk team, generate the go code, and then do the comparison. This process is inconvenient and slow.

It would be easier for us to debug when there is a potential protobuf version mismatch between turbo-go-sdk, and the canonical version.

probe lack interface to add action policy and entity metadata

Current implementation of turbo.probe does not provide the interface to add action policy for entities.

Without this interface, two issues may occur:
(1) The default values of the action policy may change over time, which may break kubeturbo;
(2) Won't be able to change the settings of the entities. For example, containerPod should be able to be Cloneable, but the default settings for containerPod may be not.

ProviderType for EntityDTO_CommodityBought is not set

EntityDTOBuilder does not set the ProviderType for CommodityBought:

for providerId, commodities := range providerCommoditiesMap {
	p := providerId
	commoditiesBought = append(commoditiesBought, &proto.EntityDTO_CommodityBought{
			ProviderId: &p,
			Bought:     commodities,
		})
}

Only the providerID is set. It works for now, but not sure whether this will cause problem in the future.