Comments (8)
I think it's a good feature, but not one that should involve too much changes, we should try to avoid adding something too complex for a feature that the user can implement by himself in a bunch of lines of code.
the tg.flash.TGFlash class can probably be modified to use a template instead of plain string substitution and also make possible to pass a dictionary as the message instead of a string. Would that be a good enough solution? In that case we can probably manage to make something that is fully backward compatible but also makes possible to render templates inside the flash.
from tg2.
I'm playing around here: https://github.com/moschlar/tgext.flash
from tg2.
The workshop branch has a different implementation that doesn't rely anymore on webflash and supports python3, if you want to experiment there we can easily merge a proposed patch that keeps backward compatibility.
https://github.com/TurboGears/tg2/blob/workshop/tg/flash.py
from tg2.
Should be TG>=2.3 compatible in https://github.com/moschlar/tgext.flash/tree/38887b6b084c3e10cd58283c4d071c9941162ab3
I only use imports which are present in <2.3 and >=2.3 .
Maybe we can merge it after some more refinements, I'll tell the mailing list about it, maybe someone has ideas ;).
I'd like to keep it available as an extension so it is usable for <2.3, too!
from tg2.
This is something which looks great to have but is missing some core features. Can we extend tgext.flash with the missing JS support (which is foundamental when used with caching) or should we provide a custom implementation in TurboGears itself?
from tg2.
See also #52
from tg2.
Solved by 07fc5e2 documented at http://turbogears.readthedocs.org/en/development/turbogears/webflash.html#flash-options
from tg2.
👍
from tg2.
Related Issues (20)
- Using Kajiki & Jinja simultaneously doesn't work HOT 2
- configuration error: no challengers - Documentation for TG2 REST API with Bearer Token Authentication? HOT 1
- vontri gher HOT 2
- In quickstart template /error/document crashes if accessed directly
- Message in ErrorController should not include html tags
- Hooks documentration version 2.4.0 HOT 2
- Issues with @cached(type='memory') and no Accept-Language header HOT 1
- Error: tg.i18n.LanguageError: No translation file found for domain HOT 2
- "TypeError: No object (name: context) has been registered for this thread" when use config.__getitem__ in tgschedule
- kajiki include/import DOCTYPE tag HOT 2
- Python 3: TypeError (no context) which was not present on Python 2 HOT 2
- TurboGears2 and pytest conflict HOT 3
- ErrorPageApplicationWrapper without TraceErrorsMiddleware will mute tracebacks
- Secure attribute for webflash cookie HOT 3
- SQLAlchemy version conflict with TG2.4.3 devtools/SQLAlchemy >=1.4 and zope-sqlalchemy 1.4
- turbogears.org website certificate is expired HOT 1
- Activating Genshi lenient mode in Tg2
- localedir is overrides and not working
- Route/HTTP middleware after method should execute after exception response generate
- Error with objectproxy globals and current versions of mock
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tg2.