Coder Social home page Coder Social logo

TurboGears2 and pytest conflict about tg2 HOT 3 CLOSED

kiilerix avatar kiilerix commented on June 8, 2024
TurboGears2 and pytest conflict

from tg2.

Comments (3)

amol- avatar amol- commented on June 8, 2024

Given the pretty uncommon chances that a StackedObjectProxy is used as a callable and the even less common chances that it gets decorated, I think that 77132ba is a reasonable work-around to the problem.

I hoped that removing __call__ support from the object would have solved the issue, but it seems that unwrap doesn't check that what is being provided is a callable at all.

from tg2.

kiilerix avatar kiilerix commented on June 8, 2024

Yeah, that seems like an OK way to avoid the problem. Thanks.

  1. Considering that AttributeError usually has args[0] like module 'os' has no attribute 'foo', perhaps use something more helpful than just foo. Perhaps something as no 'context' has has been registered for this thread and there is thus no attribute 'foo'.

  2. But this also leads to the question of whether it just always should fail with AttributeError instead of TypeError.

  3. If not always returning AttributeError, then perhaps do it for all __ methods - not just __wrapped__.

  4. Can you recommend a workaround for using pytest doctest with existing TG2 versions?

from tg2.

amol- avatar amol- commented on June 8, 2024

Probably going for all dunder methods makes sense. I'll update the patch.

Regarding how to avoid problem with current version. I think that the issue comes from the fact that it's exploring all variables exposed in modules or something like that. Maybe changing from tg import request to things like import tg and then using tg.request instead of just request might fix the issue.
A similar issue has also been reported for Flask (who uses threadlocal objects too) with pytest a few times, even though I think it's the first time I see it in the context of doctest.

from tg2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.