Coder Social home page Coder Social logo

freshsliderjs's Issues

demo.html may not work

Hi Tuan,

We have these lines of code in demo.html

<script src="http://code.jquery.com/jquery-1.9.1.js"></script>
<script src="freshslider.min.js"></script>

If someone clones the repository and try to run demo.html from the browser, it wont' work unless they have to manually change freshslider.min.js to freshslider.1.0.min.js.

Lots of "ReferenceError: event is not defined" appearing on console.

When I ran the demo provided in the index.html file, I encountered lots of ReferenceError: event is not defined on Firebug console. After a quick look, the problem seems to be arising from the lines

if(event.preventDefault){
    event.preventDefault();
}

It happens in two places on freshslider.1.0.0.js file:

  1. mousemove listener function in line 248
  2. mousedown listener function in line 186

It seems that the event argument is received as e and not as event. I was able to solve the bug by the replacing event with e as follows:

if(e.preventDefault){
    e.preventDefault();
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.