tsunejui / fops

fops is a simple command-line application

Hi there 👋

welcome! visit my blog 👉 https://tsunejui.github.io/

你好，我是Rex, 軟體工程師。 我喜歡編寫乾淨、可維護和可測試的code，並使用unit test最佳實踐提供合理的coverage。

Hi, I'm Rex, a software engineer. I like write clean, maintainable, and testable code and provide reasonable test coverage using unit testing best practices.

Contact

Email: [email protected]

LinkedIn: https://www.linkedin.com/in/tsungjui-wu-845965141/

Twitter: https://twitter.com/tsunejui

Gists: https://gist.github.com/tsunejui

 ____                 ____  _  _    _             _
|  _ \   ___ __  __  / ___|(_)| |_ | |__   _   _ | |__
| |_) | / _ \\ \/ / | |  _ | || __|| '_ \ | | | || '_ \
|  _ < |  __/ >  <  | |_| || || |_ | | | || |_| || |_) |
|_| \_\ \___|/_/\_\  \____||_| \__||_| |_| \__,_||_.__/

created by https://github.com/sepandhaghighi/art

fops's Issues

replace CLI implementation with 3rd-party library cobra

Try replacing your own CLI implementation with well-known CLI library github.com/spf13/cobra.

try doing blackbox test by using separate test package

Try blackbox testing your packages by simply adding suffix _test to testing package name eg.

- package linecount
+ package linecount_test

Then modify tests to use exported APIs only without losing coverage rate.

refine code structure

It seems to me that the directory src should contain source code (ie. .go files) only, and independent packages should be sub-directories of pkg.

So please refine these:

• Rename src > docs and update the links in README (use relative link path in the same repo)
• Move packages (except cmd) into directory pkg

set app version

Try using build time flags to set the application version instead of setting hard-coded value at runtime: How to set package variable using -ldflags -X in Golang build

binary file detection

Please check the references below and find a way to detect non-text files.

And please remember to add related tests and revise the README, thank you.

[1] http.DetectContentType
[2] gabriel-vasile/mimetype

fix typo

The package expection should be exception, right?

build and publish release in TravisCI pipeline

Please integrate build process into TravisCI with version tagging for #2, and also publish a release automatically with built executable.

use cobra.Command's hook RunE to simplify the error handling

cobra has a hook RunE func(cmd *Command, args []string) error returns error that the command handler returns. Try using this hook to simplify the cascading error/exception handling from subcommands to the top-level root command.