truocphan / json-duplicate-keys Goto Github PK

If you set the empty string using the set method you can longer set anything else.

Code to reproduce:

temp = jdks.JSON_DUPLICATE_KEYS({})
temp.set('', "asdf")
temp.set("foo", "bar") #returns False

Some preliminary testing looks like switching the order of the if statements in set fixes the issue. I moved the elif that looks for a zero length name_split_first to the second test instead of the third and it lets you set new values again. I can submit a PR if that would help.

Hello 👋

I run a security community that finds and fixes vulnerabilities in OSS. A researcher (@mk7120) has found a potential issue, which I would be eager to share with you.

Could you add a SECURITY.md file with an e-mail address for me to send further details to? GitHub recommends a security policy to ensure issues are responsibly disclosed, and it would help direct researchers in the future.

Looking forward to hearing from you 👍

(cc @huntr-helper)