trungvose / angular-tetris Goto Github PK
View Code? Open in Web Editor NEWTetris game built with Angular and Akita ๐ฎ
Home Page: https://tetris.trungk18.com
License: MIT License
Tetris game built with Angular and Akita ๐ฎ
Home Page: https://tetris.trungk18.com
License: MIT License
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Describe the bug
Doesn't really work on mobile, it was confused between click event and the zoom in of the mobile gesture
To Reproduce
Steps to reproduce the behavior:
Just play the game on an iPhone and do multiple taps on the screen.
Expected behavior
Should functional well on mobile
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Desktop version work pretty well
Smartphone (please complete the following information):
Describe the bug
After playing a while, when i lose. the game restarts in the middle of another game. With lots of squares filled.
As reported in https://twitter.com/thugGauss/status/1286539433391661056?s=20
To Reproduce
Steps to reproduce the behavior:
In progress. The root caused might be of the invalidated state after game over for the first time. I would have to init a new state.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Probably on the web
heyyy sry to say this but im nub and i cant find the html or wich file to play and i had go thru these all file however i cant run it still
Describe the bug
The sound mute status resets to its initial state (unmuted) with the game reset.
To Reproduce
Start a new game, mute the sound, then reset the game (or lose it) and start a new game, the sound is not muted anymore.
Expected behavior
When sound is muted, if you lose or reset the game and start again, the sound should still be muted.
Desktop:
Suggested solution
The value for the mute status might be stored in LocalStorageService
same way it's done for maxPoint
Note
Not sure if that's actually a bug as it might behave this way intentionally, but from users'/players' perspective it would be better to not reset the mute status.
Thanks for this awesome game :)
Is your feature request related to a problem? Please describe.
Reading the project code, I saw that in the AngularTetris component the Query objects are accessed through the Services objects, but at the same time the Query objects are instantiated and used in the AngularTetris component. So I think these accesses have to be modified for the AngularTetris component only uses Service objects and encapsulate the accesses to Query objects.
Describe the solution you'd like
Move the accesses made to Query objects from the AngularTetris component to messages in the corresponding Service objects.
I will work on this change.
Additional context
I will change this:
...
export class AngularTetrisComponent implements OnInit {
drop$: Observable<boolean>;
isShowLogo$: Observable<boolean>;
filling: number;
constructor(
private _tetrisService: TetrisService,
private _tetrisQuery: TetrisQuery,
private _keyboardService: KeyboardService,
private _keyboardQuery: KeyboardQuery,
private _soundManager: SoundManagerService,
private _el: ElementRef,
private _render: Renderer2
) {}
...
To this (implementing the refactor):
...
export class AngularTetrisComponent implements OnInit {
drop$: Observable<boolean>;
isShowLogo$: Observable<boolean>;
filling: number;
constructor(
private _tetrisService: TetrisService,
private _keyboardService: KeyboardService,
private _soundManager: SoundManagerService,
private _el: ElementRef,
private _render: Renderer2
) {}
...
hey , i cant run these , like maybe an html or application choose to run, or i have all src code ed but when i run it on google it doesnt show up only can refer to code thing
Describe the bug
Constantly Alert 'Sorry lah, cannot play sound'.
To Reproduce
Expected behavior
A clear and concise description of what you expected to happen.
Desktop (please complete the following information):
Chrome 83
Additional context
Refer to sound-manager.service.ts
The problem seems to happen at the process of decodeAudioData
https://stackoverflow.com/questions/10365335/decodeaudiodata-returning-a-null-error
https://stackoverflow.com/questions/42739112/decodeaudiodata-unable-to-decode-audio-data
When i hit Pause button, the label of button should be updated to play but is still displaying Pause causing confusion to users
Describe the feature
I like play tetris and this project, and I feel that the feature hold_piece would be a good contribution to this project for people who play tetris and often use this functionality. Like in this tetris game .
Describe the solution you'd like
I will do some deep research on the project code and work to incorporate this functionality, visually and functionally.
Additional context
I know many people who like to play tetris with this functionality (I include myself).
The result who I expected would be something like this, adapted to this project(visually):
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.