truemmerer / animated_wallpaper_helper

Manage animated_wallpaper

Hi there 👋

animated_wallpaper_helper's Issues

Filenames with spaces in them

Hello,

Just been playing around with this script and found a bug in awp/awp.sh.
It looks like, spaces in filenames make it crash for many reasons.
One of the reasons is call to gsettings, another might be animated-wallpaper.
Part of the path is most probably interpreted as the next command arguments.

Solution:
I believe it would be enough to add a quote characters around the paths in script, where variables are involved.

For example:
Instead of this: mkdir -p $Bilddir
Something like this: mkdir -p "$Bilddir"

It should be amended everywhere in awp.sh in my opinion.

Not working at all.

Screencast.from.2022-12-17.14-36-08.webm

Change source for animated-wallpaper

Hi,

It is worth to change source for git repository animated-wallpaper.
Instead of cloning Ninlives/animated-wallpaper, stable fork would be better to download and to use.
I can see that Truemmerer/animated-wallpaper fork exists, so supposedly it was originally intended?

However update of Truemmerer/animated-wallpaper will be also required as it seems to be a bit outdated and doesn't work.
(Tested on Fedora 36, GNOME 42.6)

How does this sentence in the README make sense?

animated_wallpaper_helper/README.md

Line 31 in 97d1896

1. The X11 version of GNOME is recommended for this, as this will only work on a Wayland workspace.

Isn't this a contradiction?

Wallpaper disappear at every restart

On PopOS, the wallpaper turn black everytime I restart the computer.

I install it using a youtube video and that work well.
the video got downloaded at ~/Videos/Animated_Wallpapers/rising_light_animated.mkv and got converted to webm at ~/Videos/Animated_Wallpapers/rising_light_animated-convert.webm

So at next restart I have to re-run the script and re-create the wallpaper using a local path (To not re-download all the video)

If you need any other info, just tell me.

Default storage folder

From @FlrQue

My second suggestion would be to replace $Bilddir and $Download variables with only one called $rootDir and point it to ~/Videos/Animated_Wallpapers. This is just example location, it could be still user's homedir instead of "Videos". (P.S. according to xdg-user-dirs, you are making a lot of noise in homedir )

---

Inconsistent storage location

Greetings!

Issue is that awp.sh uses variable $Bilddir and $Download as storage location.
However, later on - when saving lastpicture.txt and lastvideo.txt files - it ignores that variable and goes with ~/Animated_Wallpapers.

I suggest moving these text files to the hidden .cache directory in user's homedir (~/.cache/Animated_Wallpapers ?).

My second suggestion would be to replace $Bilddir and $Download variables with only one called $rootDir and point it to ~/Videos/Animated_Wallpapers. This is just example location, it could be still user's homedir instead of "Videos". (P.S. according to xdg-user-dirs, you are making a lot of noise in homedir )

This small change will make this script more complaint with common standards and, honestly, a lot more friendly.

youtube-dl

youtube-dl has serious download speed issues, use yt-dlp instead https://github.com/yt-dlp/yt-dlp
I'll try to create a PR on this next week

New Existing Dialog

I would like to make the selection dialogue more user-friendly and therefore switch to the list dialogue that is fed by an array.

https://help.gnome.org/users/zenity/stable/list.html.en

awp.sh starts as a root if is ran right after installation

I will try to resolve this - posting just for the reference.

Floating `fi` at end of file

There seems to be a floating fi right at the end of the install.sh file. Removing the fi does not seem to stop the installer, but my arch desktop refused to run awp.sh after the installation because of insufficient permissions.

Automatic Install doest Work On Ubuntu 22.00 LTS