trreeves / superagent-legacyiesupport Goto Github PK

I've noticed that superagent-legacyIESupport.js has been saved as UTF-8 with BOM. (byte order marker)

When I build my project with Webpack (without minification enabled) the script throws an error "Invalid or unexpected token" at the start of the superagent-legacyIESupport bundle.

Note: this does not happen when Webpack minification is enabled as the minification strips out all unnecessary whitespace.

I encountered a problem when making a cross-domain POST in IE9 when one of the query parameters in an Object. The request looks like:

request
    .post('remote-url')
    .send({
        string: 'foo',
        number: 10,
        object: { someProp: true }
    })
    .use(superagent-legacyIESupport)

The resulting request looks like string=foo&number=10&object=%5Bobject%20Object%5D.

I'll submit a pull request with the changes I made to fix this.

Thanks for this great superagent plugin!

I had trouble getting a CORS POST to work in IE10 until I disabled this plugin. No Content-Type was sent so the server errored with 415 Unsupported Media Type. I started looking through the plugin code to investigate.

I see several mentions of shimming IE8 and IE9, but is this plugin also meant to affect IE10? That version seems to support CORS with XMLHttpRequest.

Should the check for typeof XDomainRequest !== "undefined" be amended to typeof XDomainRequest !== "undefined" && !("withCredentials" in (new XMLHttpRequest())) ?