Comments (7)
Hmmm, i see your problem - let me check what we can do about this.
from transitions.
I really hate it when gems just override methods without telling you. But on second thought i think that this check is indeed pointless since most people will define the state machine at the top of the file rendering this check useless.
I'd say we remove it alltogether - what do you think?
from transitions.
I'm +1 on just removing it, not super useful in the current implementation.
from transitions.
I will remove it in the next couple of days - currently I am travelling without my oh so precious ssh keys or a laptop for that matter..:)
from transitions.
If you're good with it, I think that'd be the best solution.
Thanks.
from transitions.
I know you said you'd remove... Just want to document a use case that I had with this in case you implement a different way:
I'm having trouble with loading a schema in Rails because of this as well. If I delete out the database (or try to use in memory, or change to another DB), then:
When I load the schema or run rake db:migrate
- it loads model definitions
- Which includes ActiveModel::Transitions
- Which of executes
machine.klass.new.respond_to?(method_name)
- Which connected to DB to check if "state" is defined there
- which fails because the table doesn't exist yet
It works when adding to a model that already exists, just not a brand new setup. Rails 3.2.6
from transitions.
@jwo thanks, all the more reason to remove this check.
FYI @ALL I removed this feature and released version 1.0.1.
Thanks everybody!
from transitions.
Related Issues (20)
- getting "uninitialized constant ActiveRecord::Transitions" with rails 4.1 HOT 2
- can_event methods don't respect guards HOT 1
- Initial state is not set HOT 3
- Problem with Success Callback HOT 5
- Refactor our specs big time
- Introduce rubocop and auto-fix offenses HOT 1
- Fix all remaining rubocop offenses in lib/ and add rubocop to our travis build HOT 1
- Transitions#set_initial_state is forcibly inserting the "state" attribute HOT 6
- new feature: put exception as a param to event_failed HOT 1
- Success callback not fired HOT 1
- Passing parameters to events HOT 1
- Raise error when guard fails HOT 6
- Throw out callbacks... HOT 5
- Introduce Reek for CI HOT 1
- Introduce RDL
- available_state available_events should list states or events in the order they are defined HOT 4
- undefined method `state_machine' for nil:NilClass HOT 4
- Multiple timestamps on state transition HOT 3
- Publish 1.3.0 release HOT 2
- Tapioca DSL compiler interest?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from transitions.