Coder Social home page Coder Social logo

Comments (7)

troessner avatar troessner commented on June 16, 2024

Hmmm, i see your problem - let me check what we can do about this.

from transitions.

troessner avatar troessner commented on June 16, 2024

I really hate it when gems just override methods without telling you. But on second thought i think that this check is indeed pointless since most people will define the state machine at the top of the file rendering this check useless.
I'd say we remove it alltogether - what do you think?

from transitions.

bnmrrs avatar bnmrrs commented on June 16, 2024

I'm +1 on just removing it, not super useful in the current implementation.

from transitions.

troessner avatar troessner commented on June 16, 2024

I will remove it in the next couple of days - currently I am travelling without my oh so precious ssh keys or a laptop for that matter..:)

from transitions.

psycotica0 avatar psycotica0 commented on June 16, 2024

If you're good with it, I think that'd be the best solution.
Thanks.

from transitions.

jwo avatar jwo commented on June 16, 2024

I know you said you'd remove... Just want to document a use case that I had with this in case you implement a different way:

I'm having trouble with loading a schema in Rails because of this as well. If I delete out the database (or try to use in memory, or change to another DB), then:

When I load the schema or run rake db:migrate

  1. it loads model definitions
  2. Which includes ActiveModel::Transitions
  3. Which of executes machine.klass.new.respond_to?(method_name)
  4. Which connected to DB to check if "state" is defined there
  5. which fails because the table doesn't exist yet

It works when adding to a model that already exists, just not a brand new setup. Rails 3.2.6

from transitions.

troessner avatar troessner commented on June 16, 2024

@jwo thanks, all the more reason to remove this check.

FYI @ALL I removed this feature and released version 1.0.1.

Thanks everybody!

from transitions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.