Comments (3)
There's already a feature branch for it: https://github.com/troessner/transitions/tree/remove_support_for_multiple_state_machines
from transitions.
I believe it's an important feature to define multiple state machines on a single object. It's a lot better to have a few separate state machines, than a single big.
from transitions.
It's a lot better to have a few separate state machines, than a single big.
That I agree 100% with. I am not advocating having a huge state machine, I am advocating to have different models for different concerns.
I remember we had this discussion already.
However, you didn't address my arguments from above:
Regarding (1):
Back then you cited: https://github.com/qoobaa/pioneers/blob/master/app/models/game.rb as an example where multiple state machines per model made sense. However, looking at the model, I can see that it is huge: Almost 500 lines. Static code analysis tools like reek clearly detect this as a code smell.
( $ ) reek app/models/game.rb
Game has at least 31 methods (LargeClass)
If you split up that model into several models (which it should be), I doubt that you would need multiple state machines.
Can you give me one example with one small and self-contained model which passes smell tests where multiple state machines make sense?
Because I have yet to see one.
Regarding (2)
As I said, the notion of having multiple state machines is not clearly expressed in the API, or better said: Not at all.
Also there are a lot of questions regarding the semantics, see my arguments from above.
from transitions.
Related Issues (20)
- getting "uninitialized constant ActiveRecord::Transitions" with rails 4.1 HOT 2
- can_event methods don't respect guards HOT 1
- Initial state is not set HOT 3
- Problem with Success Callback HOT 5
- Refactor our specs big time
- Introduce rubocop and auto-fix offenses HOT 1
- Fix all remaining rubocop offenses in lib/ and add rubocop to our travis build HOT 1
- Transitions#set_initial_state is forcibly inserting the "state" attribute HOT 6
- new feature: put exception as a param to event_failed HOT 1
- Success callback not fired HOT 1
- Passing parameters to events HOT 1
- Raise error when guard fails HOT 6
- Throw out callbacks... HOT 5
- Introduce Reek for CI HOT 1
- Introduce RDL
- available_state available_events should list states or events in the order they are defined HOT 4
- undefined method `state_machine' for nil:NilClass HOT 4
- Multiple timestamps on state transition HOT 3
- Publish 1.3.0 release HOT 2
- Tapioca DSL compiler interest?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from transitions.