Events do not change state about transitions

[JohnPostlethwait]

I had this same issue but using it as a plugin.

I dug into it and found that in the lib/active_record/transitions.rb file in the "def write_state" there is the update_attributes! call. This always returned true but WOULD NOT change the state.

I made a brand-new Rails app, added the plugin, set up a model with transitions (the same transitions I was using in my failing app) and it worked just fine. I have no idea why that is but if I change the update_attributes call in that method to be this instead it works in both apps:

self.state = state.to_s
self.save!

I am unsure why this is, as update_attributes! should work just fine and returns as if it had...

[jotto]

guys, i just forked a version with an improved readme that should explain how to get this working with rails: http://github.com/jotto/transitions/blob/master/README.rdoc

i made a pull request too.

thanks for your work qoobaa

[tekin]

This may have been because you had protected the state attribute with attr_protected/attr_accessible. The update_attributes! method will not update protected attributes. I've forked and fixed here: http://github.com/tekin/transitions, pull request on the way.

[qoobaa]

Does it work in the current version?

[tekin]

yes, as of http://github.com/tekin/transitions/commit/c0fc41bd006ae05719dc092176fb48a0682123af.

[qoobaa]

Thanks.

[JohnPostlethwait]

Wow, tekin, that is exactly the issue... I can't believe I didn't notice that. I always seem to shoot myself in the foot with attr_accessible.

Thanks for pointing that out!

[tekin]

No worries. Deleting my fork now that changes have been pulled in.

[tekin]

I've just had a thought regarding this, update_attribute skips the callback stack (including validations) whereas update_attributes! didn't. This is obviously undesirable behaviour, although might not bite anyone right away. I'll produce another patch to make sure validations aren't skipped by transitions.