troelskn / bucket Goto Github PK

When setting an instance with bucket_Container::set(), the classname is lowercased and then stored in bucket_Scope::$instances. But since bucket_Container::get() doesn't lowercase the classname, the instance you set isn't found, and a new instance is created instead.

Am I correct in understanding that any class that has an array or string parameter would require its own factory? (i.e. there's no way to say: when instantiating PageController use $config for the parameter 'config'?)

Hi Troelskn,

Firstly, thanks a lot for your great work with Bucket. I downloaded the last version as of today and tried your example code as below:

$bucket = new bucket_Container();
$bucket->registerImplementation('Zap', 'Foo');
$cuux = $bucket->get('Cuux');
var_dump($bucket);

Result from var_dump:
protected 'instances' =>
array
'foo' =>
object(Foo)[12]
...
'cuux' =>
object(Cuux)[11]
...

Shouldn't I need to call $bucket->create('Cuux'); before or does it autocreate the object properly if it doesn't exist when running $bucket->get('Cuux')?

Thanks!

I'm creating an application that will use self-contained modules, and each module would have it's own factory class. The factory I will pass to Bucket will basically be a proxy to the module factories through __call. But since Bucket uses method_exists and not is_callable, that can't be done. How about changing method_exists to is_callable?

@troelskn Could you protect the master branch so it can only be updated using pull requests?

I have extended bucket to be "self aware" and in my case act as a singelton and be able to insert itself as a parameter when creating instances - maybe something you would consider adding to the source?

Just wondering if there is some plan on making it compatible with PHP 5.3 namespaces?

There are some issues with relative vs absolute scope (which can be overcome) but the main issue is with the factory calls (cant make a new_\My\Name\Space\Class function). Without a proper rewrite there are two quick ways to resolve this:

1. Translate the namespace separator to something else - in this case '_':

function create($classname) {
    $classname = $this->scope->getImplementation($classname);
    $funcname=strtr($classname,'\\','_');
    if (isset($this->factory->{'new_' . strtolower($funcname)})) {
      return call_user_func($this->factory->{'new_'.$funcname}, $this);
    }
    if (method_exists($this->factory, 'new_' . $funcname)) {
      return $this->factory->{'new_'.$funcname}($this);
    }
    return $this->createThroughReflection($classname);
}

1. Instead of checking for the existence of the 'new_' function call it and require the factory to have a __call catchall method that either handles the classname conversion or returns false.