troeger / moodleteacher Goto Github PK

[this might be a moodleteacher issue]

Currently, the moodle comments contain text like

ostern.c:1:10: fatal error: Windows.h: No such file or directory
 #include 
          ^~~~~~~~~
compilation terminated.

The problem is that the source fragment '<windows.h>' is copied literally into the HTML comment, which is then rendered by the browser with ignorance.

In automated processes (cron), if the Moodle server is down, the connection attempt is made infinitely, which may not be convenient.

Perhaps allowing a configuration of maximum connection attempts would allow in such cases a controlled exit by, for example, an exception.

Maybe, something like this:

class BaseRequest():

  def __init__(self, conn, url, attempts = 0):
    self.conn = conn
    self.url = url
    self.attempts = attempts

 def get_absolute(self, params=None):
    [...]

    _logger.debug("Performing web service GET call ...")
    nattempt = 0
    while (nattempt < self.attempts or self.attempts == 0):
      nattempt += 1
      try:
        result = requests.get(self.url, params=params, timeout=self.conn.timeout)
      except requests.exceptions.Timeout:
        _logger.error("Timeout for GET request to {0} after {1} seconds, trying again.".format(self.url, self.conn.timeout))
        continue
      break

    if nattempt == self.attempts:
      raise Exception('Max. number of connection ({0}) attempts reached'.format(self.attempts))

     [...] 

    return result

We have the same problem as thhese guys:

https://stackoverflow.com/questions/69596494/unable-to-import-freegames-python-package-attributeerror-module-collections

The library should be fixed, and an according CICD test be realized for different Python versions.

Grading groups leads to the problem that after grading the first member, the second group member still shows up as to be graded.

This is mainly a caching problem, since alle gradings to be done are fetched as one at the beginning. The library should internally determine the groups and their members, and should consider already graded groups explicitely during the iteration process.

A re-validation overwrites the feedback box for the submission completely, so manual additions for the first validation run are gone.

The feedback saving should use some 'magic' markers in the text, put the validation result inside them and replace only this part of the text.