Coder Social home page Coder Social logo

add-pr-review-checklist's People

Contributors

sloede avatar

Stargazers

avatar

Watchers

avatar avatar avatar avatar avatar avatar

add-pr-review-checklist's Issues

Actions fails if PR description is empty

As evidenced in trixi-framework/Trixi.jl#1621: https://github.com/trixi-framework/Trixi.jl/actions/runs/6050032003/job/16418450269

TypeError: Cannot read properties of null (reading 'includes')
    at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:15143:16), <anonymous>:9:17)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async main (/home/runner/work/_actions/actions/github-script/v6/dist/index.js:15236:20)
Error: Unhandled error: TypeError: Cannot read properties of null (reading 'includes')

I believe this can remediated by first verifying that description is non-null before checking its contents:

add-pr-review-checklist/action.yml

Lines 27 to 33 in 6df9e97

const description = result.data.body;
if (description.includes('${{ inputs.no-checklist-keyword }}')) {
console.log('Checklist creation disabled by keyword "${{ inputs.no-checklist-keyword }}" in PR description')
return false;
} else {
return true;
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.