trietptm / optimice Goto Github PK

IDA 6.0.0110224

Alt+O is reserved for Options menu. Binding to, say, Alt + N works

What steps will reproduce the problem?

Part of the Input code:

push    small 85Eh
mov     bx, 7Bh
mov     eax, 1
pop     bx

What is the expected output? 
No Fault

What do you see instead?

Failed to assemble [MOV bx, small 85Eh]

What version of the product are you using? On what operating system?
V 0.13

Please provide any additional information below.

It seems that the small modifier is handled as part of the operand value and 
passed thru the optimisation.

Starting optimization @ [0040d62c]
NOTE: INSTRUCTION NOT RECOGNIZED [PUSHFW] @ [0040d62d] [['PUSHFW']]
PUSHFW
[]
-------------
Traceback (most recent call last):
  File "E:/Programme/ida61adv/Optimice v0.13/code/Main.py", line 64, in wrapper
    optimice()
  File "E:/Programme/ida61adv/Optimice v0.13/code/Main.py", line 19, in optimice
    f = Function.Function(ea)
  File "E:/Programme/ida61adv/Optimice v0.13/code\Function.py", line 92, in __init__
    self.startAnalysis(self.start_ea)
  File "E:/Programme/ida61adv/Optimice v0.13/code\Function.py", line 468, in startAnalysis
    modified |= dead_code.ReduceBB(self.basic_blocks[prev_block_ea])
  File "E:/Programme/ida61adv/Optimice v0.13/code\CodeOptimization.py", line 108, in ReduceBB
    delta_taint = bb[delta].GetTaintInfo()
  File "E:/Programme/ida61adv/Optimice v0.13/code\Instruction.py", line 82, in GetTaintInfo
    self.taint = self.CalculateInstructionTaint()
  File "E:/Programme/ida61adv/Optimice v0.13/code\Instruction.py", line 448, in CalculateInstructionTaint
    if x86InstructionData[mnem].has_key(op):
KeyError: 'PUSHFW'
-------------

What steps will reproduce the problem?
The code:
push    ebp             ; OPTY@[00001060];
mov     ebp, esp
push    ebx
push    esi
push    edi
pop     eax
cmp     ecx, eax
pushf
xor     eax, eax
pop     edi
pop     esi
pop     ebx
pop     ebp
retn

will be optimised to:
push    ebp             ; Origin@[00401010];
mov     ebp, esp
push    ebx
push    esi
mov     eax, edi
pushf
xor     eax, eax
pop     edi
pop     esi
pop     ebx
pop     ebp
retn


What is the expected output? What do you see instead?
push    ebp             ; Origin@[00401010];
mov     ebp, esp
push    ebx
push    esi
mov     eax, edi
cmp     ecx, eax
pushf
xor     eax, eax
pop     edi
pop     esi
pop     ebx
pop     ebp
retn


What version of the product are you using? On what operating system?
V0.13

Please provide any additional information below.
The CMP instruction is changing the FLAGS, that are pushed next.
So I thing the CMP shall not be removed as "dead code"