trezor / trezor-android

:iphone: TREZOR Communication Library for Android

trezor-android

Trezor Communication Library for Android

Trezor Manager app is now obsolete!

Using the library

You can add the library via jitpack. Add to jitpack as a repository:

allprojects {
    repositories {
        maven { url 'https://jitpack.io' }
        ...
    }
}

Then you can add the dependency like this:

dependencies {
    compile 'com.github.trezor.trezor-android:trezor-lib:<current_version>'
    ...
}

You can see what to best use for <current_version> in the jitpack badge on the top.

Please consider using gradle witness to improve security.

Requirements

Trezor has to be connected to Android by OTG cable. The Android device needs to support such connections.

trezor-android's Issues

Replace protobuf client implementation with wire

Protobuf is still quite heavy - especially method-count wise - perhaps (opinions welcome - cc @prusnak) we should replace it with wire:
https://github.com/square/wire

Add EthereumSignMessage

I would like to use message signing in the app, but it seems like it is not yet supported by the android sdk.

Google Play version serving older firmware

Version on Google Play (1.0.3) is still serving 1.4.2 FW

https://play.google.com/store/apps/details?id=io.trezor.app

Does not work with TREZOR 1 anymore

While investigating walleth/walleth#255 - I noticed that even the stock TREZOR manager does not work with TREZOR 1 anymore - Model T works

PS: I do not run the latest firmware 1.6.1 on the TREZOR one - perhaps this is part of the problem - but I also currently do not want to update in case this has anything to do with the errors

Outdated help link

please change help url from http://doc.satoshilabs.com to https://wiki.trezor.io in app

New logo/icon proposal

Good day sir. I am a graphic designer and i am interested in designing a logo for your good project. I will be doing it as a gift for free. I just need your permission first before I begin my design. Hoping for your positive feedback. Thanks

Can't perform ETH transaction on Android / blank screen on trezor device (model T)

Hi team
I'm trying to perform an ETH transaction using a trezor model T and getting a blank screen on the trezor when trying to sign a transaction, am I passing the params correctly? Previously the trezor would return "failed safety check" however since manually converting the to address to a byte[] (see the initial for loop) the device screen is just blank....

                String toMinusZerox = to.substring(2, to.length());

                int len = toMinusZerox.length();
                byte[] data = new byte[len / 2];
                for (int i = 0; i < len; i += 2) {
                    data[i / 2] = (byte) ((Character.digit(toMinusZerox.charAt(i), 16) << 4)
                            + Character.digit(toMinusZerox.charAt(i+1), 16));
                }


                BigDecimal weiValue = Convert.toWei(amount, Convert.Unit.ETHER);
                ByteString toByteString = ByteString.copyFrom(data);
                ByteString weiValueByteString = ByteString.copyFrom(weiValue.toBigInteger().toByteArray());
                ByteString gasPriceByteString = ByteString.copyFrom(GAS_PRICE.toByteArray());  //BigInteger.valueOf(2500)
                ByteString gasLimitByteString = ByteString.copyFrom(GAS_LIMIT.toByteArray());  //BigInteger.valueOf(21000)
                ByteString noOnceByteString = ByteString.copyFrom(noOnce.toByteArray());

                TrezorMessage.EthereumSignTx.Builder builder = TrezorMessage.EthereumSignTx.newBuilder();
                builder.clear();


                TrezorMessage.EthereumSignTx ethReq2 = builder
                        .setTo(toByteString)
                        .setValue(weiValueByteString)
                        .setGasLimit(gasLimitByteString)
                        .setGasPrice(gasPriceByteString)
                        .setNonce(noOnceByteString)
                        .setChainId(4) //rinkerby
                        .setDataInitialChunk(ByteString.EMPTY)
                        .setDataLength(0)
                        .setTxType(1)
                        .build();

                Message result = trezorDevice.sendMessage(ethReq2);

                new android.support.v7.app.AlertDialog.Builder(this).setTitle("Success")
                        .setMessage(result.toByteString().toStringUtf8().concat(" something concat-ed"))
                        .create()
                        .show();```

Text in pop-ups is unreadable, black-on-black issue

Tested on VisionBook 10Qa 3G Tablet.

Wrong firmware header when trying to install firmware onto Trezor One

It happens only with Trezor One, no issues with Trezor T.

Steps to reproduce:

1. Plug in the device with no firmware installed
2. Click on INSTALL FIRMWARE in the app
3. It seems like the installation process is starting - "Preparing" is displayed on device
4. The process results with a "Wrong firmware header" error

Add to FDroid

can be assigned to me - will make the PR for FDroid

error

I downloaded the latest version trezor-android,But still can`t build.

Protocol buffers not released

Without the protocol buffer source, it's not really possible to do pretty much anything without this library.

I started copy&pasting this library into my own test project (because this project doesn't work at all in Android Studio and it's not really anything you can import as a java lib), and it's not even possible to fetch keys from testnet, only a numeric counter of keys.

I'd like to extend this a little bit, but with generated classes only, it's pretty much impossible

Release for TREZOR T

The IDs are already added via 6530585 - but there was no release with this change yet.

Set u2f counter after recovery

Set U2F counter after recovery.

This is how I do it in mytrezor in beta

setU2FCounter(session: TrezorJsSession): Promise<any> {
    if (this.supports('u2f')) {
        const timestamp: number = Math.floor(Date.now() / 1000);
        return session.setU2FCounter(timestamp);
    } else {
        return Promise.resolve();
    }                                                                                                          
}

setU2FCounter calls the message SetU2FCounter.

App gets into inconsistent state

App gets into inconsistent state with these steps:

1. start app, connect device
2. turn passphrase on (or off, if it's on)
3. disconnect the device
4. the device is still showing up as connected, even when it's connected
5. clicking on any action shows up "loading" animation, which never stops

Interestingly, there is no way to stop this animation. Even when I uninstall and re-install the app (!!!), the loading is still showing. The only way to stop it is to reboot the phone.

Similar way to get to the same state (doesn't work 100% always) is:

1. start app, connect device
2. exit from the app by tapping "home" button
3. disconnect device (without the app on screen)
4. go back to the app, the device is showing as connected
5. clicking on any action shows up "loading" animation, which never stops

My phone is Lenovo P70. I couldn't reproduce the bug on a different Samsung phone. But the first sequence of steps always reproduces the error on my Lenovo.

Trezor is working fine with MyCelium on the same phone, but I haven't tested it as thoroughly as this app.

Java files are not encoded as text on github

Adding a .gitattributes file should be all that is needed.

*.java        text

Example of mistyped file:

• TrezorMessage.java

option to create wallet with 256 bits master key, and SLIP39

It seems with Trezor Manager I can only create a wallet with just 12 words, so 128 bits master key.
Not adequate for a long term HODL.

Ideally I want to be able to choose the master key size myself (between 128 and 256), and I'd also want to be able to create a SLIP39 setup from the Android app.

Solve backward compatibility problems

currently as far as I see it is hard to be backward compatible (e.g. caused by trezor/trezor-firmware#136 - but it seems there where also other changes)

So should the library only target one version of the TREZOR? I guess some people hesitate updating their TREZOR and there are old versions around. Wonder if satoshi labs has some analytics/insights on what versions people use?

Anyone has ideas on how to work around this? Would really love the library to be compatible with as much TREZOR versions as possible - but all solutions I can currently imagine to achieve this look are ugly and come with drawbacks.

File not found

I compile trezor-android resource code,But show me file not found:https://jcenter.bintray.com/android/arch/lifecycle/runtime/1.0.3/runtime-1.0.3.aar,Help me please!Thank you!

Screenshots for F-Droid

You can add Screenshots for F-Droid, too, if you want.

https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/

https://gitlab.com/snippets/1895688

update firmware to 1.6.1

TREZOR Manager App doesn't offer update firmware to 1.6.1

gradle sync failed

I download the latest version from github, then open project with android studio 3.2.1, occure error at during rebuild project.
error log: No dependency for integrity assertion 'com.android.tools.analytics-library:protos:26.1.2:protos-26.1.2.jar:52672a0b42b572a06aecc3535d5068eb46c0e15d129b9f1085d3c16a1da5cdbb'

Do I have to install anything else, please guide me, many thanks

[REQ] Please publish version Trezor Manager v2.1.1 to the play store (or to releases)

Looks like there are some major changes to how the bootloader does flashing since the last release of this app. Trezors with current bootloaders cannot perform flash operations:

Steps to reproduce:

1. On a PC perform trezorctl firmware-update
2. On a PC perform trezorctl wipe-device --bootloader
3. On Android launch Trezor Manager v2.10.0
4. Connect Trezor to Android and attempt to flash firmware

Observe failure.

Add some Ethereum logos for homescreen

Currently you have a lot of Options for using the Bitcoin-Logo on the HomeScreen.
I would like to see some options with the Ethereum logo here - as I rarely use Bitcoin lately and will use the TREZOR mainly in the Ethereum context ;-)
I think at some point there will be more users using TREZOR in combination with Ethereum than with Bitcoin..

Doesn't work with Alcatel tablet

Application doesn't work with tablet Alcatel One-Touch Tab 8HD

Android 4.1.1

It works with MyCelium.

Add gradle-witness

As this is security-relevant software it should use:

https://github.com/WhisperSystems/gradle-witness

I can PR it if wanted

Jitpack release v2.0.9 failed

Build for latest release v2.0.9 has failed https://jitpack.io/com/github/trezor/trezor-android/v2.0.9/build.log

Tag master branch with release numbers

As of now, missing tags on master branch, declaring version of library.
Please add tags and keep changelog between versions.

No warning in the app if the device with backup failed connected

Trezor One, Trezor T

Steps to reproduce:

1. Connect a device with backup failed warning

Result: there is no warning or instruction in the Trezor Manager.

Cannot resolve symbol 'TrezorMessage'

I complie project Ok, but in MainActivity.java file occure Cannot reslove symbol 'TrezorMessage', what should I do, help me , many Thanks

my build.gradle file
buildscript {

repositories {
    google()
    jcenter()
}
dependencies {
    classpath 'com.android.tools.build:gradle:3.1.2'
    classpath files('libs/gradle-witness.jar')
}

}

allprojects {
repositories {
google()
jcenter()
}

project.ext {
    support_version = "27.0.2"
    sdk = 27
    minsdk = 15
}

}

task clean(type: Delete) {
delete rootProject.buildDir
}

Missing LICENSE

Just realized there is no licence here - this blocks #15 and walleth/walleth#15
I would suggest MIT here

ANDROID TOOLS VERSION

Maven repository

Can you please publish both snapshots and releases on Maven repository?
Either create Maven repository in branch here on Github or publish into Maven Central.

build_pb.sh depends on vanished types.proto

still existed here:

https://github.com/trezor/trezor-common/blob/dd8ec3231fb5f7992360aff9bdfe30bb58130f4b/protob/types.proto

but vanished with d480b2b45ab7fe0aa08855e3a8bd967e575381f9 - so build_pb.sh is failing

Missing source files for Protobuffer generator

Missing source files declared in com.satoshilabs.trezor.protobuf/*.java files
namely

• messages.proto
• storage.proto
• types.proto

TREZOR in all caps everywhere in Trezor Manager App

Trezor Manager App for Android still has "TREZOR" in the name of the app and also everywhere in the app: "Complete the action on TREZOR device", "Connect your TREZOR" etc.

TREZOR Manager steals the session from Mycelium?

I can't use Mycelium with TREZOR since I installed TREZOR Manager app.

When I connect TREZOR to my phone, TREZOR Manager asks: "Open TREZOR Manager when this USB device is connected?". If I press OK, it opens the manager app. If I press Cancel, nothing happens.

In any case, when I run Mycelium, it doesn't ask me if I want to use the USB device in Mycelium and I can't force Mycelium to "search" for it in any way.