treblereel / gwt3-processors

Set of goodies for J2CL apps

Hi My name is Dmitrii Tikhomirov

Software Engineer at Red Hat

• 🌍  I'm based in North Vancouver, Canada
• ✉️  You can contact me at [email protected]

Skills

Socials

Badges

My GitHub Stats

Support Me

gwt3-processors's Issues

@GWT3Export doesn't work for classes with constructor that has args ...

public class Export {

    private final App app;

    public Export(App app) {
        this.app = app;
    }

    @GWT3Export
    public void layout(String yaml) {
        app.layout(yaml);
    }
}

GWT3Export does not work when annotation added by XMLMapper annotation processor

Following treblereel/mapper-xml#81 on XMLMapper I get a model class like the following:-

@XmlAccessorType(XmlAccessType.FIELD)
@XmlType(name = "", propOrder = {
    "header",
    "miningBuildTask",
    "dataDictionary",
    "transformationDictionary",
    "model",
    "extension"
})
@XmlRootElement(name = "PMML")
@JsType
@GWT3Export
@XMLMapper
@Configuration(additionalAnnotation = {
    @Configuration.ConfigurationAnnotation(JsType.class),
    @Configuration.ConfigurationAnnotation(GWT3Export.class)
})
public class PMML {

    @XmlElement(name = "Header", required = true)
    protected Header header;
    ...
}

The important things to understand are:-

• The class PMML is a DTO that has a (un)marshaller generated by the @XMLMapper annotation
• The PMML DTO needs to be exposed through JsInterop and the boiler-plate J2CL @GWT3Export generated.

This worked fine.

However the generated (un)marshaller also needs exposing through JsInterop and J2CL boiler-plate generated.

This is why I now add the @Configuration annotations.

However when I attempt to J2CL compile the application I receive the following error:-

/home/manstis/workspaces/git/manstis/marshaller/marshaller-api/target/gwt3BuildCache/0.17-SNAPSHOT/marshaller-api-b8fb723b2f15496d22b830c894a5776cbc13fb79/closure-inputs/com/anstis/pmml/model/PMML_XMLMapperImpl.impl.java.js:64: 
Originally at:
/home/manstis/workspaces/git/manstis/marshaller/marshaller-api/target/gwt3BuildCache/0.17-SNAPSHOT/marshaller-api-b8fb723b2f15496d22b830c894a5776cbc13fb79/closure-inputs/com/anstis/pmml/model/PMML_XMLMapperImpl.native_js:1: ERROR - [JSC_UNDEFINED_VARIABLE] variable com_anstis_pmml_model_PMML_XMLMapperImpl is undeclared
  1| const _PMML_XMLMapperImpl = com_anstis_pmml_model_PMML_XMLMapperImpl
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/home/manstis/workspaces/git/manstis/marshaller/marshaller-api/target/gwt3BuildCache/0.17-SNAPSHOT/marshaller-api-b8fb723b2f15496d22b830c894a5776cbc13fb79/closure-inputs/com/anstis/pmml/model/PMML_XMLMapperImpl.impl.java.js:66: 
Originally at:
/home/manstis/workspaces/git/manstis/marshaller/marshaller-api/target/gwt3BuildCache/0.17-SNAPSHOT/marshaller-api-b8fb723b2f15496d22b830c894a5776cbc13fb79/closure-inputs/com/anstis/pmml/model/PMML_XMLMapperImpl.native_js:3: ERROR - [JSC_UNDEFINED_VARIABLE] variable PMML_XMLMapperImpl is undeclared
  3| goog.exportProperty(_PMML_XMLMapperImpl, 'INSTANCE', PMML_XMLMapperImpl.$static_INSTANCE__com_anstis_pmml_model_PMML_XMLMapperImpl);
     ^^^^^^^^^^^^^^^^^^

2 error(s), 0 warning(s)

The files are in the following ZIP:-
PMML_XMLMapperImpl.zip

@GWT3Export doesn't work if method has underscore

KOGITO-5652: GwtExport should use interface name if present

See https://issues.redhat.com/browse/KOGITO-5652

I have submitted a PR with a simple failing unit test.

Fortunately, putting together the test highlighted that it is the package name causing problems and not the interfaces.

Even more fortunate is that I am not a supersticious person so having submitted PR #13 does not faze me!

It must be possible to use @GWT3Export and @ES6Module against one single ES6 class

@Gwt3Expport must honor overriden methods