trebek / pydealer Goto Github PK

Will be great if the package is available from pypi,

Here is a good doc how it works.

http://guide.python-distribute.org/contributing.html

Then in the readme you can explaing that to download the last stable version the following command can be used:

pip install pydealer

Pull request #20 fixes this.

Thanks

I have installed pydealer using pip. It works well using python2. However, when I try to use it using python3, I have the following error:
AttributeError: 'module' object has no attribute 'Deck'
>>> import pydealer
>>> dir(pydealer)
['builtins', 'cached', 'doc', 'file', 'loader', 'name', 'package', path', 'spec']

You probably mean build()...

I saw this project /r/python, and it looks really solid. Got a small recommendation: add __str__, __repr__, __hash__, and __eq__ to the Card class. This will allow me to do this:

c = Card('Ace', 'Spades')
print(c)
c2 = Card('Ace', 'Diamonds')
print(c == c2)

I suggest something like this:

def __str__(self):
    return '%s' % (self.name)

def __repr__(self):
    return 'Card(value=%r, suit=%r)' % (self.value, self.suit)

def __hash__(self):
    return hash((self.value, self.suit))

def __eq__(self, other):
    return isinstance(other, Card) and self.value == other.value and self.suit == other.suit

I'm a big fan of implementing these 4 methods for base classes like Card because then I can use them in data structures (set, dict, etc.) without having to worry about unexpected behavior. I can also print a card and print card-related errors and get meaningful information.

I'm trying to simulate some magic tricks and I need a function that just names a random card without dealing it from the deck. Do you have a suggestion for the best way to do this?

A little more detail

• create deck
• shuffle deck
• deal 1 card from deck
• name and random card and see if it is the same as the dealt card (this is the function I need)

Thanks

When one adds instances of a subclass of Stack or Deck, a Stack or Deck is returned instead of the expected subclass.

In spain we are a quite different an we use the Spanish Stack (Called baraja in spanish [1]) instead of the French One.

I'm curious if you wan't to support this stack also, as a lot of code can be shared with the French one.

http://en.wikipedia.org/wiki/Baraja_%28playing_cards%29

I can provide the code if you want.

Any thoughts on supporting a multiple deck feature? I'm looking at doing a blackjack sort of simulator, but want to have a dealer that has done a multiple deck shuffle (e.g. double deck BJ, 6 pack, 8 pack, etc).

Thanks!