trdlo / client175 Goto Github PK

What steps will reproduce the problem?
1. Launch server.py
2. Open the client on the browser
3. Restart MPD (i.e. /etc/rc.d/mpd restart)

What is the expected output? What do you see instead?

Expected: the server reconnects succesfully and the UI is functional again. 
(and everything is a bed of roses :P)

The server detects the disconnection and tries to reconnect. But it fails and 
an exception is thrown.

After this point the UI is no longer usable.

Stack trace:
{{{
Connection lost while reading line
    reconnecting...
ERROR IN MPD_POLLER: [Errno 111] Connection refused
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 530, in __bootstrap_inner
    self.run()
  File "/opt/client175/mpd_proxy2.py", line 94, in run
    self._connect()
  File "/opt/client175/mpd_proxy2.py", line 80, in _connect
    self.con.connect(self._host, self._port, self._password)
  File "/opt/client175/mpd.py", line 419, in connect
    self._sock = self._connect_tcp(host, port)
  File "/opt/client175/mpd.py", line 407, in _connect_tcp
    raise socket.error(msg)
error: [Errno 111] Connection refused
}}}

Presumably the 1s sleep is not enough and there's only one attempt to reconnect.

Hi,

It seems that you left some debugging code in server.py. Line 75:
HOST = "192.168.1.2"

Greets,
Tim

Here is an ebuild and init script for client175.

What steps will reproduce the problem?
1. Install following apache instructions
2. Connect to client175
3. View error log

What is the expected output? What do you see instead?

The errorlog has lots of these errors:

[14/Feb/2013:10:57:25] MOD_PYTHON Traceback (most recent call last):
  File "/home/music/client175/cherrypy/_cpmodpy.py", line 139, in handler
    setup(req)
  File "/home/music/client175/cherrypy/_cpmodpy.py", line 82, in setup
    mod = __import__(modname, globals(), locals(), [fname])
  File "/home/music/client175/server.py", line 76, in <module>
    mpd = mpd_proxy.Mpd(HOST, PORT, PASSWORD)
  File "/home/music/client175/mpd_proxy2.py", line 48, in Mpd
    _Instance = _Mpd_Instance(host, port, password)
  File "/home/music/client175/mpd_proxy2.py", line 144, in __init__
    self._connect()
  File "/home/music/client175/mpd_proxy2.py", line 157, in _connect
    self.con.connect(self._host, self._port, self._password)
  File "/home/music/client175/mpd.py", line 423, in connect
    self._hello()
  File "/home/music/client175/mpd.py", line 366, in _hello
    raise ConnectionError("Connection lost while reading MPD hello")
ConnectionError: Connection lost while reading MPD hello

The UI mostly works - the playlist *sometimes* doesn't show, same with the 
track/album info, though if i look in the webbrowser's debugger i can see 500's 
all over the place:

GET http://music.0xff.co.uk/static/ext/resources/css/xtheme-slate.css 500 
(Internal Server Error) index.html:39
POST http://music.0xff.co.uk/playlistinfoext 500 (Internal Server Error) 
ext-base.js:7
GET 
http://music.0xff.co.uk/covers?file=1stgig-bits%2F%5BOZC%5DGhost%20in%20the%20Sh
ell%20Stand%20Alone%20Complex%20Clean%20OP%20(Alternate%20Broadcast%20Ver.).mp4&
artist=&album= 500 (Internal Server Error) ext-all-debug.js:451
POST http://music.0xff.co.uk/lyrics 500 (Internal Server Error) ext-base.js:7

As far as i can tell the error in the apache logs are the same for each 500 
regardless of which request is made.

Here is my site.log: http://paste.ubuntu.com/1649604/
Here is my site.conf: http://paste.ubuntu.com/1649623/
Here is my apache config: http://paste.ubuntu.com/1649647/

Thanks in advance,

Paul

It would be nice if you could configure the ip/host of mpd different of the 
webservice for the client.

What steps will reproduce the problem?
1. untared client175 on arch linux build with all dependencies
2. modified the site.conf to include the music dir
3. ran python server.py

What is the expected output? What do you see instead?
expected outcome is server should be working. received error:

# python server.py
  File "server.py", line 208
    print args
             ^
SyntaxError: invalid syntax


Please use labels and text to provide additional information.

i tried to run the server as both root and local user. it had the same error 
both way. any help would be great. Thank you!

What steps will reproduce the problem?
1. When I create a playlist on another computer and paste it in MPD's playlists 
directory it won't show in client175 playlists.
2. But if I edit some mp3 tags and metadata all the playlists are rescanned and 
then show up in client175 
3. Can you make a button to rescan all the playlist and refresh the client175's 
playlist folder

I have started client175 and no errors are reported.  However, when I browse to 
the page I get the following output:

500 Internal Server Error

The server encountered an unexpected condition which prevented it from 
fulfilling the request.

Powered by CherryPy 3.1.2

Is there a log I can look at to determine whats going wrong?

Was wondering if you could not display coverart and fit as many songs on the 
right pane as possible without coverart? Thank you.

BTW, thanks for the wonderful webui for mpd. Its really nice.

It would be great if you could add password-protection.

Is it possible to make client175 run on other webservers as well? I tried 
getting it to work on lighttpd but I didn't succeed.

What steps will reproduce the problem?
1. Expand "Folders" in the navigation pan on the left
2. Try to access a folder with accents
3. The content of the folder cannot be seen

Attached is the output on stdin when it happens.

For client settings and mpd settings like outputs, crossfade, etc

It would be cool to at least _write_ song ratings.
And write not to song tags, but to mpd sticker file, like gmpc do.

I would like to request this feature (or at least its implementation as a 
setting).

The current behaviour when replacing a playlist (e.g. by right clicking an 
album and choosing "Replace Playlist") stops the current track playback and 
replaces the playlist.

The desired behaviour is to do the same but also start playing the first track 
of the new playlist right away.

Hi,

I don't known if it is possible todo, but it should be nice if you could add a 
http video music stream and let the video display in small resizeable window.

thanks for the great client ;)

Kind regards,
DavidR

None of the newer mpd clients support this so I think it would be nice for 
client175 to support this. It will make it get ahead of the pack :)

Let me start by saying this UI amazed me when I found it.  Surprised what can 
be done in a browser.

Now I appreciate you didn't design this for an iPad but the beauty of having a 
PC connected to the sound system and having a "wife friendly" way of 
controlling it is a killer app in my house.  Not sure how you could make money 
from this on the Apple App store but the other MPD version for iPad is a few $.

The following are issues running on an iPad with iOS 5.0.1.  My MPD database 
has about 44,000 tracks so there is a good data set to work on.

Volume slider - if I press and hold on the volume slider then drag the screen 
will drag not the slider.  I can click on a place on the slider to get it to 
move but that is rather hard due to the size.  Not sure if you have any control 
over this slide control, not sure of the alternatives.

When I use the search in the top right for say "Garfunkel" it displays the 
results in the centre pain as expected.  The problem is that I cannot double 
click to expand "Simon & Garfunkel", the act of double tapping cause the screen 
to expand.  Would it be possible to have an "expand" icon on this line to 
achieve the same thing?

There is no way to move the bars that create the 3 separate panes.  This is not 
a problem because it sizes correctly in the first place and the hide & expand 
buttons work well on the left pane.

I got strange results using the "Artist / Albums" > "Minimum 10 songs" items.  
I got the animation, a pause and no data.  I am guessing that as I have a lot 
of data and a slow device that this timed out gracefully.  Again not sure if 
there is any way to tune this.

When I use the expand gesture to zoom the screen collapses and the layout goes 
all wrong.  If I pinch it back to normal size it springs back to normal and 
works fine again.

I also tried this on my Android phone and the same sort of results (but the 
screen is too small).

If a longer playlist is loaded this make it easier to find the current line of 
the playlist to see which songs came next.

When I run 'python server.py' the server does not start.  Instead, I get this 
error output:

Traceback (most recent call last):
  File "server.py", line 47, in <module>
    mpd = mpd_proxy.Mpd()
  File "/var/www/localhost/htdocs/client175/mpd_proxy2.py", line 52, in Mpd
    _Instance = _Mpd_Instance(**kwargs)
  File "/var/www/localhost/htdocs/client175/mpd_proxy2.py", line 174, in __init__
    self._connect()
  File "/var/www/localhost/htdocs/client175/mpd_proxy2.py", line 204, in _connect
    self.con.connect(self._host, self._port)
  File "/var/www/localhost/htdocs/client175/mpd.py", line 338, in connect
    self._sock = self._connect_tcp(host, port)
  File "/var/www/localhost/htdocs/client175/mpd.py", line 329, in _connect_tcp
    raise socket.error(msg)
socket.error: [Errno 111] Connection refused

I don't see any place to enter the port which MPD is using, could this be the 
problem?

On random occasions, updating a file's tags will clear any unchanged tags from 
the file.  Very annoying.

I cannot find any pattern to this behavior yet...

First thing: this is the best webclient I have seen so far.  It is just simply 
amazing.
However, my basic stress test, adding my complete album collection to the 
database fails utterly.  It starts tanking CPU for a while, and then nothing.

What steps will reproduce the problem?
1. Add like 20.000 items to the playlist.
2. Wait.
3. Wait.
4. Cpu usage drops, playlist stays empty.

What is the expected output? What do you see instead?
I would have liked to see the playlist content.

Please use labels and text to provide additional information.
Running on a Celeron 400 with 512 MB ram. 

I have Client175 setup behind an Apache server.  After accessing the Client175 
web interface, I'm no longer able to connect to MPD from other client. It looks 
like Client175 has exclusive access to MPD until I stop my Apache server.

Is this a known behavior?  Is there anything I can do to prevent this?

Thanks!

As MPD now also is available as Win32 binary, I decided to test client175 on my 
windows 7 based server.

Client175 uses the pwd module, which is unavailable on Windows. I removed the 
lines of code that had something to do with this (4 or so lines in server.py 
that have RUN_AS and/or pwd in them). Obviously now the server cannot be run as 
a different user. I'm not sure if this is a security risk or not.

Other than that client175 seems to work fine on Windows. So my suggestion is to 
create an alternative for the setuid() or to bypass it just on windows based 
systems.

problem is contentcontent["query"]["search"] doesn't exist - because the return 
is 

{u'error': {u'info': u'text search is disabled', u'code': 
u'srsearch-text-disabled'}}

My solution was to just ignore the exception

    try:
        for t in content["query"]["search"]:
                titles.append(t["title"])
    except:
        pass

It would be great to make use of the ID3v2 feature to have multiple values for 
tags like artist and genre. I tagged my music with foobar2000 and in Client175 
either only one of the values shows up or something like "Metal\\Sludge 
Metal\\Sludge Doom" which seems to come from the older proprietary foobar 
format that might also be considered dut to its popularity.

i like to use the consume feature with mpd.  there is no way to turn this 
on/off currently (that i could find), so hacked it in based on the repeat and 
random work.

these are the changes i made (can probably be done better, particularly the 
'height' of the control area:

main.js:
37,38c37
<                 region: 'north',
<       height: 100

---
>                 region: 'north'

mpd.control.js:
62,74d61
<         var btnConsume = new Ext.Button({
<             iconCls: 'icon-consume',
<             text: 'Consume',
<             x: 190,
<             y: 56,
<             enableToggle: true,
<             toggleHandler: function(btn, state) {
<                 var val = (state) ? '1' : '0'
<                 if (val != mpd.status.consume) mpd.cmd(['consume', val])
<             }
<         })
< 
< 
203d189
<       btnConsume,
324,328d309
< 
<   mpd.events.on('consume', function () {
<             var val = (mpd.status.consume == '1')
<             btnConsume.toggle(val)
<         })

style-css:
165,170d164
< .icon-consume {
<   background: url("icons/fugue/arrow-consume-gray.png") no-repeat !important;
< }
< .x-btn-pressed .icon-consume {
<   background: url("icons/fugue/arrow-consume.png") no-repeat !important;
< }

would really like to see the consume option implemented in client175, 
regardless if its this method of another.  i use it often and it kinda sucks to 
have to ssh in to my server and use mpc.

thanks for the work on client175, looking forward to future 
improvements/enhancements!

The actual slash in the songs name (in this case: star/pointro from the roots) 
is not escaped which results in this exception:

Star/Pointro
500 Internal Server Error

The server encountered an unexpected condition which prevented it from 
fulfilling the request.

Traceback (most recent call last):
  File "/opt/client175/cherrypy/_cprequest.py", line 606, in respond
    cherrypy.response.body = self.handler()
  File "/opt/client175/cherrypy/_cpdispatch.py", line 25, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/opt/client175/server.py", line 401, in lyrics
    with open(file_path, 'w') as f:
IOError: [Errno 2] No such file or directory: '/opt/client175/static/lyrics/The 
Roots/Star/Pointro.html'

Tested with revision 140.

Two sidebars don't fit well on 1024x768 and below, should be able to toggle 
between none, single left, single right, and both sidebars.  For none, the 
sidebar items can be moved to tabs.

i'd really like to have client 175 center the playlist on the currently playing 
song and highlight it in the playlist.  when i am not actively listening to 
music, sometimes a song comes on and i'd like to change to a song from the same 
album/artist, which is hard currently as i have to browse the playlist for the 
currently playing song.

reason this is important to me: most of the time i just add all add songs to 
the playlist (15000+ currently), turn random and consume on then hit play.  
when i get home from work, i turn the stereo on and their is music, like my own 
person radio station with no commercials.  :)  sometimes when warren haynes 
'stella blue' is on i'd like to play 'in my life' and then let mpd continue 
playing randomly when that song is over.

client175 is the best mpd frontend i've found thus far, keep up the good work!

I've been trying out client175 and must say it looks great so far.

But it's confusing me because I don't see how to start it in the background. 
I've started it the way described on wiki.
It starts and spews log data all down the screen. I tried starting it with "&" 
as a background process but it does the same. I tried piping to a log file and 
it still outputs on the terminal.

I'm trying to set it up along with MPD on a small home server.

What is the correct way to start it in background as a server, writing to a log 
file? Can this be added to the wiki? It needs to start as non-root at boot time 
right, along with mpd ideally. I can create an upstart init script for it but 
obviously it currently doesn't write to a log file...?

I'd love to get this working! It looks great - and if it works for me I'll be 
switching from Songbird to use this. I can write python code too and would love 
to contribute.

Thanks.

It might be nice when using client175 to be able to play the mpd httpd output 
stream right in the browser window.  The HTML5 audio tag should be ideal for 
this purpose.

Pro:
A separate audio player does not have to be open in addition to the web browser.

Con:
Some strange behavior occurs with every combination of stream format and web 
browser I have tried so far.

Details:
Please note that I have configured mpd to produce an httpd output on port 8001. 
 In order to test the HTML5 audio tag, I added the following code to the 
static, index html file (client175_0.4/static/index.html):

<audio src="http://127.0.0.1:8001" autoplay="autoplay" preload="none"></audio>

Everything works as expected at first.

A problem I experienced is that the browser often stops playing the stream 
after the end of each song.  I think the metadata send at the beginning of each 
new song might be causing the problem because mplayer also occasionally has a 
problem as well.  I contemplated automatically refreshing the frame with the 
audio tag but think that the buffering would then cut off the beginning of each 
song.  The problem seems to happen when the stream is vorbis rather than lame 
encoded, but in testing Firefox, Internet Explorer, and Chrome, only Chrome 
appears to be able to play an mp3 encoded stream.

Presumably there would be a checkbox or something similar to enable or disable 
the HTML5 audio tag.

Hi there,

Thanks for the reply. Is it possible to make client175 to start with just 
titles only and no coverart? Thank you sir.

Regards,
Andrew

What steps will reproduce the problem?

1. Open any folder in the middle of the screen
2. Create new tab and open another folder in it
3. repeat

What is the expected output? What do you see instead?

The program should be able to deal with insufficient space for tabs (e.g. 
compressing tab width) but it does not

(Anyway this MPD client is a great job, thx)

The server should detect an incorrectly configured music_directory and prompt 
the client to fix it.

When playing a song it should be capable of downloading covers and showing it. 
For every song I've played the cover is not shown...

...and remove the buffer server side.

What steps will reproduce the problem?
1. Use the web UI to navigate to any kind of song (saved playlist, via artist 
or genre)
2. Press either the green + button near a song or the "+Add All" button at the 
top of the list.
The Playlist in the sidebar on the right is not populated (nothing is 
displayed/empty), but pressing the "play" button starts playback normally.

What is the expected output? What do you see instead?

The Playlist in the sidebar on the right is not populated (nothing is 
displayed/empty), but pressing the "play" button starts playback normally.

The following error is logged:

HTTP Traceback (most recent call last):
  File "/opt/client175/cherrypy/_cprequest.py", line 606, in respond
    cherrypy.response.body = self.handler()
  File "/opt/client175/cherrypy/_cpdispatch.py", line 25, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "server.py", line 468, in query
    pl = mpd.getPlaylistByFile(d['file'])
  File "/opt/client175/mpd_proxy2.py", line 265, in getPlaylistByFile
    item = self._extendDbResult(pl)[0]
  File "/opt/client175/mpd_proxy2.py", line 160, in __getattr__
    fn = getattr(self.con, name)
  File "/opt/client175/mpd.py", line 188, in __getattr__
    (self.__class__.__name__, attr))
AttributeError: 'MPDClient' object has no attribute '_extendDbResult'


Please use labels and text to provide additional information.

Using another mpd client reveals that the current playlist is actually 
modified, only nothing is displayed in the client175 UI.

I am using Puppy Linux 5.1.1 with XAMPP 1.7.3a and Python 2.6

In the attached screenshot, I am showing client175 and GMPC at the same time 
connected to the same mpd server. On GMPC the playlist is populated while in 
client175 it's empty.

Thanks in advance for help.

What steps will reproduce the problem?
1. Find a song to edit with a special/non-unicode character
2. Edit it in any field
3. Save changes and see the error

What is the expected output? What do you see instead?
Editted field should be updated, get the error message instead. Other songs get 
editted.

Please use labels and text to provide additional information.
The Error message:

500 Internal Server Error
The server encountered an unexpected condition which prevented it from 
fulfilling the request.
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/cherrypy/_cprequest.py", line 645, in respond
    response.body = self.handler()
  File "/usr/lib/python2.7/site-packages/cherrypy/lib/encoding.py", line 188, in __call__
    self.body = self.oldhandler(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/cherrypy/_cpdispatch.py", line 29, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/opt/client175/server.py", line 242, in edit
    print '%s[%s] = "%s"' % (id, tag, val)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 
89: ordinal not in range(128)
Powered by CherryPy 3.2.0

Please add a favorites button like that of gmpc, if the favorites symbol is 
clicked it gets brighter and the song is added to the favorites playlist.

Would truly be awesome if the artists drop-down list could default to use the 
Album Artist tags, and if not present, fall back to the Artist tag.

This is (sadly) something that has to be done on the client side rather than 
the mpd side.

Client175 Release 0.3, MPD 0.15.4

I'm using MPD with password authorization.
After adding "mpd_password" option to site.conf, Client175 fails to start and 
shows error:
mpd.CommandError: [4@0] {tagtypes} you don't have permission for "tagtypes"

I don't understand anything in Python, but I fixed this problem by moving this 
condition

---
 if _password:
                self.password(_password)

---
four line upper, before this line

---
self._TAGS = self.tagtypes()

---

in file "mpd.py"
I belive, you can make a bit better fix in trunk :)
Thanks.

I use the output profiles for my multiroom setup, would be great if client175 
could do this for me too. now i have to use my phone app to do this seperatly.
managing radiostations like the "Gnome Music Player Client" would be also very 
nice.
Overall the best webfrontend for mpd in my opinion, and i tested a lot.
Keep on coding, it´s a marvelous piece of websoftware!

Hello, got an internal 500er error -> detailed in attached file:

500 Internal Server Error

The server encountered an unexpected condition which prevented it from 
fulfilling the request.

Traceback (most recent call last):
  File "/var/www/client175/cherrypy/_cprequest.py", line 606, in respond
    cherrypy.response.body = self.handler()
  File "/var/www/client175/cherrypy/_cpdispatch.py", line 25, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/var/www/client175/server.py", line 339, in lyrics
    txt = lyricwiki.get_lyrics(artist, title)
  File "/var/www/client175/lyricwiki.py", line 99, in get_lyrics
    lyrics = _get_lyrics(artist, title)
  File "/var/www/client175/lyricwiki.py", line 58, in _get_lyrics
    for page_title in _get_page_titles(artist, title):
  File "/var/www/client175/lyricwiki.py", line 51, in _get_page_titles
    for t in content["query"]["search"]:
KeyError: 'query'

What steps will reproduce the problem?
1. Play songs
2. Replace current play list with a new album

PHP 5.3.2-1ubuntu4.18
Firefox 18.0.2
MPD 0.15.4

Often when I replace a playlist I get

500 Internal Server Error

The server encountered an unexpected condition which prevented it from 
fulfilling the request.

Traceback (most recent call last):
  File "/home/ddula/usr/src/python/client175-read-only/cherrypy/_cprequest.py", line 606, in respond
    cherrypy.response.body = self.handler()
  File "/home/ddula/usr/src/python/client175-read-only/cherrypy/_cpdispatch.py", line 25, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "./server.py", line 146, in add
    mpd.findadd(args[0], args[1])
  File "/home/ddula/usr/src/python/client175-read-only/mpd_proxy2.py", line 262, in findadd
    self.command_list_end()
  File "/home/ddula/usr/src/python/client175-read-only/mpd_proxy2.py", line 196, in command_list_end
    return self.con.command_list_end()
  File "/home/ddula/usr/src/python/client175-read-only/mpd.py", line 451, in command_list_end
    return self._fetch_command_list()
  File "/home/ddula/usr/src/python/client175-read-only/mpd.py", line 362, in _fetch_command_list
    return self._wrap_iterator(self._read_command_list())
  File "/home/ddula/usr/src/python/client175-read-only/mpd.py", line 294, in _wrap_iterator
    return list(iterator)
  File "/home/ddula/usr/src/python/client175-read-only/mpd.py", line 287, in _read_command_list
    yield retval()
  File "/home/ddula/usr/src/python/client175-read-only/mpd.py", line 298, in _fetch_nothing
    line = self._read_line()
  File "/home/ddula/usr/src/python/client175-read-only/mpd.py", line 239, in _read_line
    raise ProtocolError("Got unexpected '%s'" % SUCCESS)
ProtocolError: Got unexpected 'OK'

MPD LOG

Feb 09 20:41 : client: [0] process command list returned 0
Feb 09 20:41 : client: [0] process command "clear"
Feb 09 20:41 : playlist: stop
Feb 09 20:41 : output: closed plugin=alsa name="My ALSA Device"
Feb 09 20:41 : client: [0] command returned 0
Feb 09 20:41 : client: [0] process command "stats"
Feb 09 20:41 : client: [0] command returned 0
Feb 09 20:41 : client: [0] process command "status"
Feb 09 20:41 : client: [0] command returned 0
Feb 09 20:41 : client: [0] process command "stats"
Feb 09 20:41 : client: [0] command returned 0
Feb 09 20:41 : client: [2] opened from 192.168.x.x:38158
Feb 09 20:41 : client: [1] closed
Feb 09 20:41 : client: [2] process command "tagtypes"
Feb 09 20:41 : client: [2] command returned 0
Feb 09 20:41 : client: [0] process command "stats"
Feb 09 20:41 : client: [0] command returned 0
Feb 09 20:41 : client: [0] process command "status"
Feb 09 20:41 : client: [0] command returned 0
Feb 09 20:41 : client: [0] process command "stats"
Feb 09 20:41 : client: [0] command returned 0
Feb 09 20:41 : client: [0] process command "play "0""
Feb 09 20:41 : client: [0] command returned -1

It looks like the displayed variables have to be cleared if no tags are found 
on the currently playing track.

Only functionality missing from this imo.

Alternatively a right-click menuitem that adds the rest of the song from the 
same album as currently selected song.

I suggest that the browser's window title should be the title of the currently 
playing song.

I'm not sure I like the property grid that much.  Also, updates can be handled 
using built in store features:
{
    autoSave: false,
    batch: true
}

Add a button to update the MPD database.