traitecoevo / baad.data Goto Github PK

As of commit d1ceb73 we have coverage of 87%

baad has two species columns: species and speciesMatched, however there is only a definition for species

e.g.

> subset(dat$dictionary, variable =='species')
  variable units   group      type has_methods essential   label minValue maxValue allowableValues                           description
9  species  <NA> species character       FALSE      TRUE species       NA       NA            <NA> latin name of species (genus species)


> subset(dat$dictionary, variable =='speciesMatched')
 [1] variable        units           group           type            has_methods     essential       label           minValue        maxValue        allowableValues description    
<0 rows> (or 0-length row.names)

I'm guessing speciesMatched is the a column that has been checked against some species name database?

Also although self explanatory there is no dictionary definition for studyName either.
For consistency I think the dictionary should match the structure of the data.
This can happen by adding definitions for the two variables I mention above.

# of columns
> length(names(baad$data))
[1] 62
# of column definitions
> length(baad$dictionary$variable)
[1] 60

Tests of baad.data are failing on windows machines (via Appveyor). In particular, the test checking the objects return the same hash is failing. From Appveyor build1.07, we have

  1. Failure: ecology version (@test-baad-data.R#12) 

  Error: testthat unit tests failed

Line 12 is the test for object hash.

Running on my machine I get the same output as is encoded in the test"

d <- baad.data::baad_data("1.0.0")
storr:::hash_object(d)
[1] "7c59e15a5d56752775e8f8e9748e3556"

@RemkoDuursma can you confirm what you get on your windows machine when you run the above two lines?

It would be great if you could also download the baad.data repo and run the tests to see if they pass.

@richfitz thanks for sharing, I really like this approach.

While presumably most people will come to this repo by way of the paper rather than the other way around, it would be nice to state what kind of data 'baad' contains in the README and repository description. (We're trying to remedy the same problem with a lot of ropensci readmes that are equally opaque, particularly whenever the database in question is some acronym). A link to your Ecology paper would likewise be handy (though I guess if it's not open access that may be less convenient for some as a way of documenting what's going on here).

We already have travis enabled, better add ensure works on windows too!
https://ci.appveyor.com/

Error:

Error in if (local) { : argument is not interpretable as logical

(windows, baad.data 1.0.1)

Hi @dfalster I'm putting together a database with a very similar design to baad–even, perhaps, partly inspired by it!–and wondered about any lessons learned/feedback you have vis-à-vis using the datastorr architecture.

https://twitter.com/BenBondLamberty/status/1122107870818869248

Thanks!