trainingbypackt / artificial-intelligence-and-machine-learning-fundamentals Goto Github PK

line 6 defines a function def succ. I think since this if for successors the actual word can be used to name the function. There is a similar funciton name in Exercises 3,4 and 5

Also you can give two empty lines above the function for readability reasons.

Running gameloop() gives and error on lines 55 and 56.

This
row = int( input( prompt='Enter row: ' ) )

should look like this
row = int(input('Enter row: '))

The input function doesn't take keyword arguments

Also it's not pythonic to leave spaces in a bracket, example ( input( "Enter row: " ) ) should be like this (input("Enter row: "))

It will be nice to add comments to all the code files so that readers of the code can understand what is going on. At the point there is none at all

I suggest using pylint or pycodestyle to make the code adhere to PEP8 standards

The image above contains 9 different print outputs. But they all seemed to be togerther. Introducing newlines at the end of print statements will make it cleaner. Expecially in files where you have more than 2 print statements.

1. Running the following modules modules gives a NameError: name 'model_selection' is not defined on line 9

• model_fitting_linear.py
• model_fitting.py
• model_fitting._fib.py

2. Plots not showing after running the following. Adding plot.show() at the end solves this issue

• model_fitting_best_fit_line.py
• model_fitting_np_polyfit.py

Hi @zsolt-nagy

Please I would like to ask if you could hold making commits while I'm reviewing the codes. I downloaded the code to my machine to review and run them so if you make commits it worries.

I see you changed the location of some activities and it's messed with the names of my issues and some of the comments. Thanks

Add plot.show() at the end of scripts to show the plot after running the code.

Numpy has been imported as np.

On line 9, numpy.matrix.transpose(A) throws a NameError

should be np.matrix.transpose(A) instead.

1. running cross_validation.py gives a NameError: name 'preprocessing' is not defined error.

2. I'm wondering why it says cross validation but we aren't doing any cross validation. Scikit-learn has a cross_val_score function for doing cross validation. I think it could be very helpful here.

NameError: name 'confusion_matrix' is not defined on line 80 of digits.py and 88 of digits_deep.py

hint: confusion_matrix was not imported

running prediction.py gives a NameError: name 'svm' is not defined on line 74

Running gameloop() gives and error on lines 63 and 64.

This
row = int( input( prompt='Enter row: ' ) )

should look like this
row = int(input('Enter row: '))

I think you should rename the exercise file from numpy.py. This can cause errors when you run the code. Because since numpy.py exists in the directory where you'll be running the code, it will import that instead of the numpy module that we installed.

1. Wrong file name used in lines 6, 24 and 37 of image_clustering.py
   hint: the file name starts with a capital letter

2. KMeans model was not imported

3. There seems to be a lot of repeated code in image_clustering.py. Can you try to use functions. Also you're loading and reading the same image inside two for loops. Can you take that process out of for loops and find a way to load it just once.

1. Please check line 6, dataFrame.replace() gives a syntax error.
   I fixed it by copying the variable name dataFrame and replacing it with that of line 6

2. Pandas is not imported. Causes it to throw and error.

• You are using a function called classification_report which is not defined. It returns the following error.

NameError: name 'classification_report' is not defined

This happens on

• line 44, cars.py Activity 13
• line 48 cars.py Activity 14

Solution:

Import classifcation_report from sklearn.metrics lik so

from sklearn.metrics import classification_report