tragiccode-refreshenvironment's People
tragiccode-refreshenvironment's Issues
Windows provider notes
Just had an opportunity to take a look at your provider code. A few notes:
- Ruby has some encoding bugs when dealing with environment variables, so on a non-English system, calling
ENV.update
can corrupt environment variables. - Puppet implemented a
get_environment_strings
andset_environment_variable
in thePuppet::Util::Windows::Process
namespace (code at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/process.rb#L236-L278) as part of Puppet 4.4.0 - you should be able to useset_environment_variable
in your code- Original PR is at puppetlabs/puppet#4592 / ticketed as https://tickets.puppetlabs.com/browse/PUP-5726 - there's more info in there on why this is necessary
- I see you're reading reg keys for env vars at https://github.com/TraGicCode/tragiccode-refreshenvironment/blob/feature/implement-type-and-provider/lib/puppet_x/tragiccode/system_environment.rb#L23 ... Ruby also has problems with encoding for some of its registry functions. We internally implemented some Registry code in puppetlabs/puppet#3540 (more info in https://tickets.puppetlabs.com/browse/PUP-3837) to work around the Ruby bugs. That bit may no longer be necessary in the current Ruby that we ship with the agent, but it was necessary for Ruby 2.1.5.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.