trademe / plunge Goto Github PK

We built Plunge using kotlinx-serialization for ease of de-/serializing, but turns out it's a barrier to entry when using the library. We should replace it with something available in JCenter - IMO Moshi is the way to go seeing as it's a relatively small API to include, but open for debate!

The installation instructions in the README are incomplete. I encountered the following issues when trying to add Plunge to my project:

• The repositories block is missing from the buildscript section
• The kotlinx-serialization dependency requires a Kotlin version > 1.3.20
• The kotlinx-serialization repository is missing for the plugin
• The line Uri.parse(getIntent().getData()) should just be intent.data (as getData() returns a Uri already)

It would be cool if Plunge could test specific URLs only for particular build variants. By using manifest merging, I can ensure that some links are only handled by a certain build variant - for example, I only want to catch a "staging.example.com" link in debug builds, and not production builds. However, with the way the testing is currently done, there's no way of doing this.

When the plungeTest* task fails, it outputs the URLs of the tests that failed, but not the description or filename. This makes it hard to understand which test failed and why.