Since the isNumber value guard uses + to convert a string to a number, this has the side-effect of treating a whitespace-only or empty string as zero. E.g. +' ' resolves to 0.

This should probably be treated as an error case. Using parseInt(..., 10) instead should resolve this.

Can we make the _reset() method differently available, so it's more easily accessible in unit testing?

E.g.: I would like to be able to do something like this:

afterEach(() => {
        // Reset for @Singleton
        let classUnderTest = (<any>CardViewModeService);
        classUnderTest._reset();
    });

But currently, calling TestBed.Get() in afterEach to retrieve it is creating a new instance of the class under test - as I'm unable to reset on the instance.

Craig suggested something more like:

var foo = function singleton() {
        if (!instantiated) {
            checkInjectable(injectable);
            instantiated = true;
            foo._reset = function () { return instantiated = false; };
            return injectable.apply(this, arguments);
        }
        throw new ensure_error_1.EnsureError("\n            " + injectable.name + " is a singleton and must not be instantiated multiple times.\n        ");
    };
    return foo;

Thanks.

isNotNull is currently special-cased to only run on get. Can we support marking custom value guard functions to run on get?

An attribute would be petty cool, e.g.

import { Guard } from '@trademe/ensure';

@Guard({ onGet: true })
function myGuard () {
   ...
}

If you use a string value enum with the isEnum guard it returns the key name rather than the enum value :(

Maz with Ben

example

enum Foo {
  aaa = 'AAA'
}

let v = isEnum(Foo)('aaa', 'someprop');
assert(v, 'AAA'); // fails as isEnum returns 'aaa'