Comments (5)
Hey, I think that's not flexible enough, go and js implementations use String, but I can suggest using generic type Clone + Eq + Hash. If type is Copy it is easy to implement Clone for it.
It cab be implemented with Generator trait
pub trait Generator: Clone + Sync + Send + 'static + Debug {
type Sid: Clone + Hash + Eq + Debug + Display + FromStr;
fn generate_sid(&self) -> Self::Sid;
}
What do you think about it?
from socketioxide.
I created a PR.
I haven't fixed docs test, it expects addition of type annotations.
From my point of view it can make project more complicated and less developer friendly.
Could you check it out? Now I'm not sure if it's really worth it
from socketioxide.
As I said in your PR, it is maybe not the best moment to add so much complexity to the codebase due to the generic.
However you can still make a fixed implementation of a fully random, fixed size generated socket id. It is the part that's bother me the most because snowflakes are predictible.
from socketioxide.
I like the idea of a Generator
trait so it allows the user to specify a custom generator function.
But it would imply to propagate another generic all around the codebase.
Idk if it is worth it but why not try and see the result !
Are you considering working on it ?
from socketioxide.
Resolved with #19
from socketioxide.
Related Issues (20)
- Inconsistent binary packet ordering HOT 3
- Automatic crate publishing
- Custom parser support HOT 2
- Feature reqwest: List all rooms HOT 1
- Using TLS to encrypt all messages HOT 2
- WebTransport support HOT 1
- Socket-io client does not upgrade to Websocket, it just works as polling HOT 3
- Add middlewares services to namespaces
- All events get blocked when socket is emitting lots of data HOT 14
- Several handlers for a single event HOT 2
- Binary packet placeholder handling does not handle all possible messages
- Relationship between `Bin` and the structure of `Data` can be ambiguous for binary packets HOT 14
- Binary events sent to handlers have a 0x4 byte prepended to the binary data (v4 server) HOT 2
- `OPTIONS` request should not return `BadHandshakeMethod` error HOT 1
- Add default event "connection" HOT 1
- Cannot keep ref to extension objects across .await points in handlers/middlewares HOT 3
- delete_ns blocks thread indefinitely HOT 1
- MongoDB Adpter HOT 1
- Hold a per `Client` state rather than a static state. HOT 1
- Unnecessary panic on Message enum match arms HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from socketioxide.