Comments (2)
Using enums sounds good to me, especially because they are on the stack which is far bettern than trait objects. When people want to implement other parsers they could then simply open a PR and try to get them officially added to the parser list.
Honestly, I haven't worked on this PR for a while now, but I'll consider taking a look and try to come up with something that can be worked with. Thanks for the suggestion!
from socketioxide.
After considering all the possibilities to solve this issue I came to think that we should simply implement the msgpack parser as an enum based solution.
enum Parser {
Common(CommongParser),
#[cfg(feature = "msgpack-parser")]
MsgPack(MsgPackParser),
}
/// Public API implemented for Parser and delegating the actions either to the
/// `CommongParser` or the `MsgPackParser` based on a flag in the configuration.
My other points for this solution are:
- Currently there are only two real parsers implementation (maybe three):
- socketio/socket.io#4934.
- Meaning that exposing a public trait and having separated libs for each parser is not really worth because we can reduce parsers to a fixed set (2 or 3).
- We won't loose any performance when using the
Common
parser by default because the enum will be reduced to only one variant (so no branching). - Here is a little comment on the two different solutions: https://users.rust-lang.org/t/performance-implications-of-box-trait-vs-enum-delegation/11957/4?u=totodore. It is quite nice to understand the advantages and drawback between these two.
@FabianHummel what are your thoughts on this? As you already started to implement something.
from socketioxide.
Related Issues (20)
- Inconsistent binary packet ordering HOT 3
- Automatic crate publishing
- Feature reqwest: List all rooms HOT 1
- Using TLS to encrypt all messages HOT 2
- WebTransport support HOT 1
- Socket-io client does not upgrade to Websocket, it just works as polling HOT 3
- Add middlewares services to namespaces
- All events get blocked when socket is emitting lots of data HOT 14
- Several handlers for a single event HOT 2
- Binary packet placeholder handling does not handle all possible messages
- Relationship between `Bin` and the structure of `Data` can be ambiguous for binary packets HOT 14
- Binary events sent to handlers have a 0x4 byte prepended to the binary data (v4 server) HOT 2
- `OPTIONS` request should not return `BadHandshakeMethod` error HOT 1
- Add default event "connection" HOT 1
- Cannot keep ref to extension objects across .await points in handlers/middlewares HOT 3
- delete_ns blocks thread indefinitely HOT 1
- MongoDB Adpter HOT 1
- Hold a per `Client` state rather than a static state. HOT 1
- Unnecessary panic on Message enum match arms HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from socketioxide.