tonk / makebackup Goto Github PK

I have tested the following change and it worked as expected:

• RSYNCOPTS="HA'
• RSYNCOPTS="-HA"

Hello Ton,

I have a few concerns about the recent changes pushed.
Specifically: 60d6844 Added / changed some syslog messages to make the better--2013-07-26

Several additional changes were made not covered in the commit message that reverse changes recently made:

1. removed the run lock file mechanism
2. removed the "added options" feature for 'rsync'
3. the revision number decreased rather than increased. Going from 43 to 40

Is is possible that these recent changes were applied to an older version of this file rather than the current ?

Tonk,

Currently, the script reports the exit status of a called pre-backup command only. Unless you see circumstances where a "proceed even if failure" is desirable, it would be better that the script not proceed, but exited, if pre-backup commands exits with non zero exit status.

My pre-backup script checks the NFS mount point destination and fixes found problems --such as not mounted as expected. But it can fail to fix a problem and exit with status 1. I would rather a backup was not attempted under this conditions.

Walter