tomudding / player-visibility Goto Github PK

I will open this creative issue again. Because doesn't InventoryCreativeEvent cancel it? At least from my testing InventoryCreativeEvent does cancel middle click, but just sometimes doesn't display it right.

Placeable blocks which are used as toggle item are placed when right clicking other blocks.

My console is sometimes spamming this error: http://pastebin.com/raw/sDLyfvCW
I'm using 2.5 plugin version, and don't know what is causing this.

Also you can duplicate slime item when you are in creative mode and middle click on them.

I downloaded this and restarted my server.
there is no new plugin folder, no config file, please help

The MIT License should be changed to the 'GNU Affero General Public License v3.0' license to provide better licensing for other projects.

Issues:

• When you change the "switch" message in the config, it will not update in-game. (fixed, see v2.4)
• Prefix doesn't appear in the "already on/off" messages. (fixed, see v2.4)
• When I have the on & off item set to an ender pearl or eye of ender then I click the item in-game, it won't deny me from using the item. (fixed, see v2.4)

Suggestions:

• Multiple lines of lore for the on & off item. (added, see v2.4)
• Option to disable the visibility status on-join. (need more information)
• Just remove the "switch" message, don't like it. (works as intended)

A quick glance over the Commands class reveals an issue. The readability of the code.

To be more specific: nested if-statements (if statements inside of an if statement). It's extremely messy, but we've all nested if statements in the past.

I recently came across this video by codecourse. He gives great examples in this vide. While the language he shows this in is PHP, it also applies to Java and other programming languages.

I'd recommend preventing nested if-statements as much as possible.

Please add support for 1.8, or make a separate version of Player Visbility that supports 1.8.