tommyshellberg / eterna Goto Github PK

This repo already has some mention to props.loading but it doesn't actually do anything. We could utilize a global "loading" prop which triggers a Spinner component when expensive operations are happening(saving to Firebase, loading from Firebase, sorting).

At the moment, the BirthdayScreen is not re-rendering the list of contacts when they change in state. We need to ensure that the FlatList component re-renders when props.upcomingBirthdays updates:

https://github.com/tommyshellberg/Eterna/blob/master/screens/BirthdayScreen.tsx#L51

https://itnext.io/react-native-why-you-should-be-using-redux-persist-8ad1d68fa48b

There are still some lingering console.log statements as well as @todo labels.

By default, the new user will not be added to the Firebase project JSON tree. They will be added after the initial sync or My Profile save event.

We could push an empty object for contacts as well as a mostly empty object for /me but include the signup email. Otherwise, the user has to type in their email again.

At the moment the contacts array is mutated by adding a tempBirthday prop in order to set the birthday to 2019. This is the only way I currently know how to check for birthdays coming up within 30 days as we need to "ignore" the birth year.

At the moment it's linked to an essentially empty reducer function:

https://github.com/tommyshellberg/Eterna/blob/master/screens/HomeScreen.tsx#L138

Contacts are sorted in order of being added rather than the first/last name.

Include instructions for cloning, setup, Firebase config, etc.

We use the disabled prop of NativeBase's Button component to toggle the button's ability to be pushed. It should also change the background color of the button as a visual indicator but this is broken as of a recent update.

Example:

https://github.com/tommyshellberg/Eterna/blob/master/.firebaserc