tomaz-suller / mvn-rs

mvn-rs

mvn-rs's Issues

Error messages could be &'static str rather than String

Using string slices would save converting from static string slices in various places.

Assembler tests are not integrated with dotenv!

Mneumonic are hard coded in tests, whereas they should all come from calls to dotenv!, like the ones in the mvn-types tests.

Use of dotenv! does not allow conversion from u8 to NormalMneumonic

Problem

As described in b17d37f, removing From<NormalMneumonic> for u8 was necessary since using results from dotenv! as patterns for a match statement were not allowed by the compiler, which complained about it being impossible to expand the macro into a pattern.

It seems this has something to do with the use of procedural macros, as for "normal" macros it seems this feature has long been added to Rust, as per rust-lang/rust#14298.

Solution

None

Workarounds

Only one I can think of is reading the hex values from the .env file and transmuting them (which is unsafe) into NormalMneumonic variants. I don't see this as too big an issue since these .env files were never meant to be managed by the final user, but only by the developers (so much so we use dotenv_codegen because the .env file is only necessary at compile time).

Types should be moved back to assembler crate

They can't really be used directly in the linker, so there's no need to keep a separate crate apart from making it harder to implement some types.