Coder Social home page Coder Social logo

Comments (10)

blowsie avatar blowsie commented on May 6, 2024 1

I think it would be great to see this, an example app which strictly follows the style guide.

from angular-1-5-components-app.

toddmotto avatar toddmotto commented on May 6, 2024 1

This is complete! Huge thanks to @benbrownlol (lol) for the epic PR: https://github.com/toddmotto/angular-1-5-components-app/tree/ES2015

from angular-1-5-components-app.

mikeerickson avatar mikeerickson commented on May 6, 2024

Local branch (will issue associated PR when when completed)

 ~/Documents/Projects/angular/angular-1-5-components-app --> 003-refactor-es6

from angular-1-5-components-app.

toddmotto avatar toddmotto commented on May 6, 2024

Hey Mike, awesome. I'll add you as a project collaborator on this so I can assign you the task. Check your emails for the invite :) thanks again!

from angular-1-5-components-app.

mikeerickson avatar mikeerickson commented on May 6, 2024

Will do!

from angular-1-5-components-app.

thomaspaillot avatar thomaspaillot commented on May 6, 2024

I take a shoot at rewriting the app in es6 (repo here). The app is working but the tests are not working yet.

from angular-1-5-components-app.

mikeerickson avatar mikeerickson commented on May 6, 2024

@thomaspaillot what are the testing issues you are experiencing?

from angular-1-5-components-app.

mikeerickson avatar mikeerickson commented on May 6, 2024

@thomaspaillot Just downloaded your repo and see what the tests are doing ;-)

I will have a closer look when I have some extra (non work) time

from angular-1-5-components-app.

thomaspaillot avatar thomaspaillot commented on May 6, 2024

@mikeerickson Firebase initializeApp method seems to be the problem, there is a mock of firebase in the mocks folder that is attached to window and I didn't find a way to properly load it with es6 module.

First experienced with webpack and es6, so I'm not totally confortable with this yet.

Glad if you could take a look at it

from angular-1-5-components-app.

toddmotto avatar toddmotto commented on May 6, 2024

I think you can just create/import/export that mocks/ firebase, it was only something I hacked together to allow testing against the app. There's no AngularFire mocks available for this new version of Firebase.

from angular-1-5-components-app.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.