toblerity / keytree Goto Github PK

A bug fix (#4) and warning about end of support for old Python versions (#7).

This project has the following syntax errors that prevent it from running in Python3:

• keytree/keytree/kml.py

  Line 92 in db7dc93

  raise ValueError, "Invalid dimensions"

  ValueError, "Invalid dimensions" should be ValueError("Invalid dimensions")

• keytree/keytree/__init__.py

  Lines 2 to 3 in db7dc93

  	from factory import feature, geometry
  	from kml import element

  from factory and from kml should be from keytree.factory and from keytree.kml respectively

I have forked the repository and made the changes, and my fork seems to be running fine in Python 3--it was just these minor syntax errors. I'm happy to contribute the fixes back to the main project and delete my fork, I just don't have the write privileges to do so.

@sgillies

New feature and type hinting. Target date: 2020-06-15.

Python 3 compatibility is the final feature.

Following the directions at https://python3statement.org/practicalities/.

We'll follow https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table and support versions 3.6+ in version 2.0.0.

Some pro-bono work I'm doing has me converting features like gx:Track into LineStrings for geojson output. I'm already writing the code to do so and would be happy to make it into a PR for this project, but I wanted to check if the interest is there before I write and submit it.