The communication's discuss from tno-mpc

View Code? Open in Web Editor NEW

TNO PET Lab - secure Multi-Party Computation (MPC) - Communication

License: Apache License 2.0

Python 100.00%

communication's Issues

Party behind port forwarder uses wrong ip handler

The server port is send as a cookie to the client. It uses the port that is used when creating the HTTPServer for this:

communication/tno/mpc/communication/httphandlers.py

Line 63 in 24b60e5

cookies = {"server_port": str(self.pool.http_server.port)}

We run the player behind a port forwarder, meaning that the port the HTTPServer listens too is not the same port the other parties can reach this server. We hacked a way of changing this behaviour by monkey patching the HTTPClient:

def new_http_client_init(self, pool, addr: str, port: int,
                         ssl_ctx: Optional[ssl.SSLContext]):
    self.pool = pool
    self.addr = addr
    self.port = port
    self.ssl_ctx = ssl_ctx
    if self.pool.http_server is None:
        raise AttributeError("No HTTP Server initialized (yet).")
    # self.session
    cookies = {"server_port": str(self.pool.external_port)}
    if self.pool.loop.is_running():
        self.pool.loop.create_task(self._create_client_session(cookies))
    else:
        self.pool.loop.run_until_complete(self._create_client_session(cookies))
    self.msg_send_counter = 0
    self.total_bytes_sent = 0
    self.msg_recv_counter = 0
    self.send_lock = threading.Lock()
    self.recv_lock = threading.Lock()
    self.buffer = {}


tno.mpc.communication.httphandlers.HTTPClient.__init__ = new_http_client_init