tmsalab / edina Goto Github PK

looks like your main function edina() is never executed and
hence not tested, since the example is wrapped in \donttest{}.

Please unwrap the examples if that is feasible and if they can be
executed in < 5 sec for each Rd file or create additionally small toy
examples.

Alternatively, you can write some tests (e.g. by using testthat). The
overall execution time should not exceed 10 minutes.

Hello,

I met a error message what about matrix size issue.

error: Mat::init(): requested size is too large; suggest to compile in C++11 mode and/or enable ARMA_64BIT_WORD

Anybody can check out this issue?
I saw https://stackoverflow.com/questions/40592054/large-matrices-in-rcpparmadillo-via-the-arma-64bit-word-define this article.

Best,
Seongho

• Passes R CMD check
• Functions documented
• Wait for a 👍

Quotes are used to mark paper titles, non-English usage, package names
and API names. Please remove them in your title and description to avoid
confusion.

Email...

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_edina.html.

pow() requires doubles not int. This was taken care of in ecdmcore... Just not propagated out.

Log results...

/inst/include/edina_meat.h:27:33: error: call of overloaded ‘pow(int, unsigned int)’ is ambiguous
vv(k) = pow(2, K - k - 1);

/inst/include/edina_meat.h:38:41: error: call of overloaded ‘pow(int, unsigned int)’ is ambiguous
double twopow = pow(2, K - k - 1);

/inst/include/edina_meat.h:141:29: error: call of overloaded ‘pow(int, int&)’ is ambiguous
double nClass = pow(2, K);

/inst/include/edina_meat.h:154:29: error: call of overloaded ‘pow(int, unsigned int&)’ is ambiguous
double nClass = pow(2, K);

/inst/include/edina_meat.h:174:35: error: call of overloaded ‘pow(int, unsigned int&)’ is ambiguous
unsigned int nClass = pow(2, K);

/inst/include/edina_meat.h:175:37: error: call of overloaded ‘pow(int, unsigned int)’ is ambiguous
unsigned int nqjs = pow(2, K - 1);

/inst/include/edina_meat.h:258:29: error: call of overloaded ‘pow(int, unsigned int&)’ is ambiguous
double nClass = pow(2, K);

/inst/include/edina_meat.h:620:35: error: call of overloaded ‘pow(int, unsigned int&)’ is ambiguous
unsigned int nClass = pow(2, K);

\dontrun{} should only be used if the example really cannot be executed
(e.g. because of missing additional software, missing API keys, ...) by
the user. That's why wrapping examples in \dontrun{} adds the comment
("# Not run:") as a warning for the user.
Does not seem necessary.
Please unwrap the examples if they are executable in < 5 sec, or create
additionally small toy examples to allow automatic testing.
(You could also replace \dontrun{} with \donttest if it takes longer
than 5 sec to be executed, but it would be preferable to have automatic
checks for functions.)
e.g. vis-auto-edina.R

Please add \value to .Rd files regarding exported methods and explain
the functions results in the documentation.
If a function does not return a value, please document that too, e.g.
\value{None}.

Possibly mis-spelled words in DESCRIPTION:
bayesian (19:24)

-> Bayesian

Found the following (possibly) invalid URLs:
URL: doi:10.1007/s11336-017-9579-4
From: README.md
Message: Invalid URI scheme (use \doi for DOIs in Rd markup)

Use DOIs either in DOI markup, or specify full URLs in URL markup as
that in your README.md.

Please only capitalize names, sentence beginnings and abbreviations in
the description text.

Found the following (possibly) invalid URLs:
URL: doi:10.1007/s11336-017-9579-4
From: README.md
Message: Invalid URI scheme (use \doi for DOIs in Rd markup)
URL: http://www.r-pkg.org/pkg/edina (moved to
https://www.r-pkg.org:443/pkg/edina)
From: README.md
Status: 404

You can refer to a CRAN package such as edina via the canonical link
https://cran.r-project.org/package=edina

Please add small executable examples in your Rd-files to illustrate the
use of the exported function but also enable automatic testing.

\dontrun{} should only be used if the example really cannot be executed
(e.g. because of missing additional software, missing API keys, ...) by
the user. That's why wrapping examples in \dontrun{} adds the comment
("# Not run:") as a warning for the user.
Does not seem necessary.
Please unwrap the examples if they are executable in < 5 sec, or create
additionally small toy examples to allow automatic testing.
(You could also replace \dontrun{} with \donttest if it takes longer
than 5 sec to be executed, but it would be preferable to have automatic
checks for functions.)