Coder Social home page Coder Social logo

Ajax loaded tabs about easytabs HOT 5 CLOSED

tmhub avatar tmhub commented on June 20, 2024
Ajax loaded tabs

from easytabs.

Comments (5)

dimdimich avatar dimdimich commented on June 20, 2024

What do you think about adding such feature to main branch or it should be paid modification?

from easytabs.

tangar76 avatar tangar76 commented on June 20, 2024

I do not think such feature should be implemented in easytabs. It has to be some custom development - some block that can load data via ajax from simple product on config option change. Then this block can be place into tabs via Magento admin interface.

from easytabs.

dimdimich avatar dimdimich commented on June 20, 2024

I think that it's quite popular way to load content on content heavy pages. Please discuss that with Vova.

from easytabs.

vovayatsyuk avatar vovayatsyuk commented on June 20, 2024

TL;DR;
It's possible but unstable. Especially regarding third-party tab contents.
So, if we will add this feature, there should be an easy way to disable it per tab.

Explantation

  • For now, tabs are rendered during catalog_product_view action with access to Request object (all params), Registry, Events.
  • If we implement some action to render tab, the tab will be rendered during easytabs_tab_render action with different environment

This may cause errors for some the tabs that require some logic that works during catalog_product_view action only.

Additionally, various js may not work as expected (dom:loaded listener for example).

from easytabs.

vovayatsyuk avatar vovayatsyuk commented on June 20, 2024

Another caveat:

Customers actively use our feature, when the tab is not rendered if there is no content for it.

This feature will not work for ajax tabs, of course.

from easytabs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.