Comments (5)
What do you think about adding such feature to main branch or it should be paid modification?
from easytabs.
I do not think such feature should be implemented in easytabs. It has to be some custom development - some block that can load data via ajax from simple product on config option change. Then this block can be place into tabs via Magento admin interface.
from easytabs.
I think that it's quite popular way to load content on content heavy pages. Please discuss that with Vova.
from easytabs.
TL;DR;
It's possible but unstable. Especially regarding third-party tab contents.
So, if we will add this feature, there should be an easy way to disable it per tab.
Explantation
- For now, tabs are rendered during
catalog_product_view
action with access to Request object (all params), Registry, Events. - If we implement some action to render tab, the tab will be rendered during
easytabs_tab_render
action with different environment
This may cause errors for some the tabs that require some logic that works during catalog_product_view
action only.
Additionally, various js may not work as expected (dom:loaded listener for example).
from easytabs.
Another caveat:
Customers actively use our feature, when the tab is not rendered if there is no content for it.
This feature will not work for ajax tabs, of course.
from easytabs.
Related Issues (20)
- Greek translation
- Floating tabs HOT 5
- Please create package without subscription checker for swisuplabs site HOT 1
- Magento 2.0 HOT 1
- Please create 2.3.7 release for swissuplabs HOT 2
- revisit layout xml update for frontend HOT 1
- new grouped design for additional info tab HOT 1
- Problem with rendering javaScript generated content HOT 1
- Upgrading from 2.3.8 to 3.2.0: Invalid Method TM_EasyTabs_Block_Tabs::isExpandedLayout HOT 2
- Add new tab type: html/xml to allow to add widgets HOT 1
- Missing conditions on second level
- Integrate with TM_AMP
- '_tabbed' suffix should be automatically added to tab alias HOT 1
- Add public events: easytabs:beforeActivate, easytabs:afterActivate HOT 1
- Wysiwyg editor for html content type
- Add conditions support to allow to show/hide easytabs
- Add observers to extennal links HOT 1
- Dynamic tabs titles HOT 1
- change how quickly the page scrolls HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from easytabs.