tivac / aws-sig Goto Github PK

When using rollup to bundle aws-sig and the rollup-plugin-node-resolve plugin the following code isn't removed from the deployed version:

It's visible on unpkg.com in the bundled output for the .esm.js version.

Was seeing some signing errors and narrowed it down to path segments needing to be encoded.

It looks like adding ".map(encodeURIComponent)" in the path function solves the issue:

function path (ref) {
        var url = ref.url;

        return url.pathname
        .replace(multipleSlashesRegex, "/")
        .split("/")
        .reduce(function (prev, curr) {
            if(curr === "..") {
                prev.pop();

                return prev;
            }

            if(curr === ".") {
                return prev;
            }

            prev.push(curr);

            return prev;
        }, [])
        .map(encodeURIComponent)
        .join("/");
}

References: (ctrl + f "segment")
https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html
https://docs.aws.amazon.com/AlexaWebInfoService/latest/CalculatingSignatures.html

https://github.com/Caligatio/jsSHA/

Might be smaller than the custom crypto-js form being included now. Need to validate perf as well as bundle size!

Should be straightforward using the rollup API, will need to figure out how to then take the generated code and run it within the same node process for validating though.

In case the client's clock is skewed from AWS.

I'm getting failures creating requests, and it looks like the issue is that X-Amz-Expires is not supported and is required for S3 Query Parameter authorization.

Ideas?