Comments (2)
Hi @takasehideki,
Thank you for the feedback. I welcome your proposed pull request.
For the record, I'll answer your question. The purpose of the command rm /etc/apt/apt.conf.d/docker-clean
is to enable auto-completion with the apt install
command inside the container's bash. There's no profound reason for the comments in the Dockerfile being added in a separate commit, though they should ideally have been included in the same commit.
Leaving the docker-clean
file results in the inability to use auto-completion with the apt install
command after running apt update
inside the container. This Dockerfile is designed for setting up and using a test environment, and having bash auto-completion available inside the container was considered beneficial for both me and the users.
However, I had not fully taken into account the impact on the image size. I agree that keeping the image size as small as possible is desirable. For now, I'll work on reducing the image size. Afterward, I'm thinking of considering adding rm /etc/apt/apt.conf.d/docker-clean
to entrypoint.sh
or something similar.
from docker-ros2-desktop-vnc.
@Tiryoh thank you so much for your kind explanation!
First, in my conclusion, the command RUN rm /etc/apt/apt.conf.d/docker-clean
should be moved to the later stage of the Dockerfile. I hope you like my PR #153 about this.
It would certainly be useful to realize apt-get auto-completion. My first suggestion of just removing this command would not allow the auto-completion even after doing apt update
. According to this page, it seems that docker-clean should be removed to realize apt-get auto-completion. By moving this command to the later, I confirmed that the auto-completion could be kept after running apt update
in the container, while greatly reducing the size of the Docker image (6.33 GB as indicated in my initial proposal).
One strange thing is that auto-completion in apt install
was enabled in the original Docker image without doing apt update
. This feature is lost by moving the command with my commit. However, I don't think it's a matter, because we can't operate apt install
without doing apt update
in the first place, and it's natural to operate apt update
first if we want to install a new package in a Docker container.
from docker-ros2-desktop-vnc.
Related Issues (20)
- Can't connect to local host after 1st time HOT 6
- unable to launch with docker compose in pycharm windows 10 HOT 1
- naming convection tiryoh/ros2-desktop-vnc:humble-arm64-20220921T0434 HOT 4
- Commit from container error vnc HOT 20
- Network Mode:host breaks the VNC connection HOT 3
- Update screenshots in README
- Unable to communicate with ROS 2 system outside of docker container. HOT 3
- Run with --net=host break access to vnc HOT 8
- /bin/bash: /entrypoint.sh: /bin/bash^M: bad interpreter: No such file or directory - Unable to run on Windows 10 HOT 3
- codium install error
- Try KasmVNC
- USB access HOT 1
- Suggestion: add terminator HOT 4
- Suggestion: enable auto completion in docker container HOT 2
- Suggestion: enable colcon-argcomplete HOT 1
- Add colcon extentions
- gazebo was blackout when I run docker image with humble tag HOT 11
- apt-get install error HOT 3
- Suggestion: add web browser HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-ros2-desktop-vnc.