tinovyatkin / babel-plugin-html-tag

Statically evaluates and minifies tagged html`<..>` template literals into strings

• 👋 Hi, I’m Konstantin.
• 💞️ I love riding horses 🐎, driving my Wrangler and collecting 🍷 wines.
• 📫 You can reach me through my twitter or LinkedIn.

babel-plugin-html-tag's Issues

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

Handling of <style> tag content

<style>
      @media only screen and (min-width: 768px) {
        ${fieldsets
          .map(
            className =>
              `fieldset.${className} { background-image: url(${basePath}${className}-1400px.${ext}); }`,
          )
          .join('\n')}
      }
    </style>

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency @types/node to v16.18.61
• Update dependency prettier to v3.0.3
• Update dependency @babel/core to v7.23.3
• Update dependency @types/babel__traverse to v7.20.4
• Update dependency eslint to v8.53.0
• Update dependency jest to v29.7.0
• Update actions/setup-node action to v4
• Update dependency @types/node to v20
• Update dependency eslint-plugin-prettier to v5
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

github-actions

.github/workflows/lint.yml

• actions/checkout v4
• actions/setup-node v3

.github/workflows/npmpublish.yml

• actions/checkout v4
• actions/setup-node v3
• codecov/codecov-action v3
• actions/checkout v4
• actions/setup-node v3

.github/workflows/test.yml

• actions/checkout v4
• actions/setup-node v3
• codecov/codecov-action v3

npm

package.json

• html-minifier-terser 7.2.0
• @babel/core 7.22.9
• @types/babel__traverse 7.18.3
• @types/node 16.18.12
• eslint 8.47.0
• eslint-config-prettier 9.0.0
• eslint-plugin-node 11.1.0
• eslint-plugin-prettier 4.2.1
• jest 29.6.2
• prettier 3.0.2
• weak-napi 2.0.2
• node >=10.10

---

• Check this box to trigger a request for Renovate to run again on this repository

escapeStaticString removes character preceding single quote

https://github.com/tinovyatkin/babel-plugin-html-tag/blob/master/index.js#L21

The problem is text.replace(/[^\\]'/g, "\\'") removes preceding character because it is part of the match i.e. my 'quoted' string becomes my\'quote\'string instead of my \'quoted\' string.

I think we can change to use negative lookbehind instead text.replace(/(?<!\\)'/g, "\\'").