tingkai-mai / pe Goto Github PK

test

test2

Issue:

The Proposed Undo/redo feature from the original AB3 is still present inside the Developer Guide.

In addition, this is under Architecture:

The codebase unfortunately also retains traces of AB3. This is confusing to developers of FoodWhere.

To Reproduce:

N/A

Expected Output:

N/A

Actual Output:

N/A

Issue:

When adding delimiters, they are case sensitive.

E.g. radd S/1 d/11-11/2022 c/test r/1 VS radd s/1 d/11-11/2022 c/test r/1.

This is an issue because the User Guide does not explicitly state the delimiter is be case-sensitive. As such, if I were an inexperienced user, I would think that S/ and s/ are the same thing.

To Reproduce:

radd S/1 d/11-11/2022 c/test r/1 VS radd s/1 d/11-11/2022 c/test r/1.

Expected Output:

Some error warning the user that delimiters are case-sensitive.

Actual Output:

Missing Index!

For example, the edit command does not have sufficient branches when you try to update a Stall to one with a same name.

Issue:

The main description/Command Summary's rfind shows that t/[KEYWORD] is not optional, when in fact it is. If it was truly optional, it would be displayed as [t/KEYWORD], with the bracket wrapped around the whole parameter. This is misleading, as now when I try to find by rfind n/someName t/, nothing appears.

I would say this is High severity, because if I try to execute the rfind command strictly, and execute t/, then I would also find reviews with no tags, which might not be what I want. I might want to see all reviews with that specified name, regardless of whether or not it has tags.

This is the same for the sfind command.

To Reproduce:

N/A

Expected Output:

N/A

Actual Output:

N/A

Issue:

In https://ay2223s1-cs2103-w14-2.github.io/tp/AboutUs.html, the "reach us at the email seer[at]comp.nus.edu.sg" does not exist. In addition, Lik Hern's profile picture is missing.

To Reproduce:

N/A

Expected Output:

N/A

Actual Output:

N/A

Issue:

I am unable to add multiple tags. Following your User Guide, there is missing documentation for how a Tag should behave. There is no description of whether multiple Tags can be added to a review or stall, and there is no stated restriction either. As such, I was left confused as to how to add multiple Tags. If indeed only one tag is allowed per stall/review, this should have been stated clearly at the start of the User Guide.

This is an expected functionality as a user: To add multiple Tags to a Stall or Review.

This is further supported by the UG, under Duplicate Checking:

"Reviews are considered duplicates if they are on the same stall and have the same content (case-sensitive), rating, date and set of tags."

set of TAGS suggests multiple tags.

To Reproduce:

Expected Output:

N/A

Actual Output:

N/A

Issue:

You can edit a Stall information without having any fields changed. For example, editing a stall with name "Z" to "Z" is allowed. Some warning or note should be raised, considering that at least one field must be provided to be edited. For example, sedit is not allowed. So, why is sedit n/sameName allowed?

To Reproduce:

Simply run the sedit command and copy over the same name.

Expected Output:

Some error should be raised when this occurs.

Actual Output:

Editing is allowed.

Issue:

If a stall with name "A B" and address "test" exists, and I try to add a stall with name "A B" and address "test" (two spaces instead of one), it tells me that a duplicate stall exists.

However, this might not be the case!

I argue this is an issue because this **would have been specified in the UG "Duplicate Checking" section.

To Reproduce:
sadd n/test test a/test
sadd n/test test a/test

Expected Output:

Allow you to add the stall.

Actual Output:

This stall already exists in the address book

Issue:

In this section, the link to the Developer Guide is broken.

To Reproduce:

N/A

Expected Output:

N/A

Actual Output:

N/A

Issue:
When adding a review, you can add the date 29 January 2001. However, as 2001 is not a leap year, 29 January does not exist. An error or warning should be fed back to the user to signal an invalid date.

To reproduce:
radd s/1 d/29/01/2001 c/TEST r/1

Expected Output:
Some kind of error signalling invalidity of date

Actual Output:
Review is added

Issue:

The display / storage behavior of a tag is not explicitly stated in the User Guide, after I input a tag. For example, if I executed radd s/1 d/1/1/2000 c/test r/1 t/TEST21, the Tag is converted from "TEST21" to "test21".

However, under:

I understood this as "I must add a Tag nonempty alphanumeric token without spaces, case insensitive", so I can do t/TEST21, but I was confused: Why was it then converted to lowercase, and displayed in FoodWhere as lowercase? (Refer to Review 7)

This is an issue as I would expect capitalization, but this was not stated in the User Guide.

To Reproduce:

N/A

Expected Output:

N/A

Actual Output:

N/A

Issue:

Some sentences' first letters are not capitalized.

To Reproduce:

N/A

Expected Output:

N/A

Actual Output:

N/A

Issue:

I can execute rlist as rlist test hello 123, but this behavior was not documented in the User Guide.

Because Phase 1 of the PE is over, I cannot log this issue as a Functionality Bug. However, I will log this as a Documentation bug because this command can be done, but the User Guide/Developer Guide does not mention that additional parameters to rlist is allowed.

To Reproduce:

N/A

Expected Output:

N/A

Actual Output:

N/A

Issue:

In rfind description, it says that "Using n/ and t/ will search name and tag fields of review respectively." Unfortunately, the NAME of the review is not defined, as because when we execute radd, we do not add a name to the review. I think it is the name of the stall, but I am not sure. Either ways, this was confusing, and is a wrong description of the command.

To Reproduce:

N/A

Expected Output:

N/A

Actual Output:

N/A

Issue:

Name of stall is unviewable when the stall name is very long. This is an issue if the stall name is super long. For example's sake, I put in some random words.

Similar thing can be done for tags.

To Reproduce:

sadd n/(Some super long name here...) a/test

Expected Output:

Output of stall with name wrapped around

Actual Output:

Name of stall is truncated

Issue:

When adding random delimiters that do not exist in the User Guide, an invalid error message is raised. This occurs when you try to do so after the "r/" delimiter, which confused me initially when I made the mistake.

This is a medium severity bug as because if I am an inexperienced user who misinputted a delimiter (one that does not exist) after the "r/" delimiter, I am presented with "Ratings can take any integer between 0 to 5, and it should not be blank" output.

To Reproduce:

radd s/1 d/11/11/2022 c/test r/4 a/test

Expected Output:

Some error message stating that there is no such delimiter "a/".

Actual Output:

Ratings can take any integer between 0 to 5, and it should not be blank