timeoff-management / timeoff-management-application Goto Github PK

It should be configurable.

As one of our customers suggested:

"It would be very helpful to be able to be to assign an approver individually for each employee rather than having the approver combined with the department."

We need to think how to add this feature without having big impact on current structure of model.

Not sure about solution at this moment yet.

System should automatically transfer all remaining vacation days to the next year.

Alternatively when calculating employee allowance previous year should be taken into consideration.

Some notes on implementation:

• Linking table to user: carried_over_allowance. With fields: id, user_id, year, carried_over_allowance, suggested_allowance
• Supervisor automatically sees missing carry overs on the my requests page (the section to be renamed into My messages)
• Employee details page allows to amend carried over but not to exceed the suggested value. In case when user want to have more, suggest manual allowance adjustments
• Send email to employee when her allowance was carried over
• Department or Company has a property that could define max amount of carried over days

In addition to the list of taken absences there should be a sum of used allowance per year.

Also list of absences to be split by years.

When adding new bank holiday and enter invalid data, e.g. leave name blank, after form submission page report success, but nothing is added.

Prevent her from:

• login into system
• showing on the team view page
• showing in the list of possible approvers
• reduce code duplication
• Make sure when updating deactivated user to be active again, system checks that such user does not exist in other companies.

Add a way for disabling some of emails on company level. It should be done as a set of checkboxes on company settings.

Emails like "notify approver for decision" etc.

By default all emails should be enabled.

As per feedback:

ability to enable and disable sending emails via web interface. Like the Ldap or at least web option on the fly to "mute" the mail sender when doing some "administrative" tasks. Currently I have to comment the config file and reboot the service.

As some customers complained the name Pavlo is not relevant to the emails from TimeOff.Management

Lets change the email signature to be just "TimeOff.Management"

As one of our customers suggested:

"How are view permissions setup? I want everyone in my company to see everyone else’s calendar regardless of the department they are in."

It sounds like very reasonable requirement and could be implemented cheaply as a flag on Company with effect on Team view. If set the Team View will show entire company not just peers. Consider to just to amend "All departments" item to show actually all departments but not employees from department current user can manage.

https://github.com/lloyd/node-toobusy

Try to book a holiday on safari

STR:

• as admin/supervisor user try to revoke someone's existing time off.
• currently it fails

Update CW when done.

If there is an attempt to revoke admin privileges from the last admin in the account: reject the action.

When my calendar page shows only four upcoming months and some of them are in new year, bank holidays from those months are not shown, even though when year is expanded to full they are shown.

Make sure employees are not able to book more vacation than allocated.

Consider adding concept of locations into companies.

So it is possible to have different sets of bank holidays within same organisation. E.g. if company has offices in different countries.

Here is a comment of one of our customers:

"... Our company is international, which brings a load of complications concerning different calendars and vacation time rules for each country. To generalize it, being able to define different sets of public holidays and determining which set a person gets is the sort of flexibility that we would need.... "

UPD.

Consider generalising concept of department into a "group" of employees.

Each such group could bring particular attribute to employee, such as bankholiday set, visibility etc.

Employees are to be part more then one of such departments/groups.

On the calendar view Upcomming months is misspelled. it should be "Upcoming Months".

We need to clean up the structure of app.js:

• how 500 page is handled
• moove session secret into config
• move handlebars setup into midleware

So customers see that TimeOff.Management can integrate with confluence/jira calendars in the same way as with outlook.

Not sure if intentional but the "Add new" button is overlapping the "Save changes" button.

Before changing button padding:

As one of our customers suggested:

"> I can provide one suggestion for a feature. It’d probably require a

bit of an overhaul and rethinking of some things, but it seems
important if you want to continue growing this for wider usage. Most
places I’ve worked for have broken down personal and vacation time
to hours, not days. Right now it seems as if your system entirely
considers things in the concept of day, and not hours, and that would
need to be reworked before we can deploy it (we have some accruals
like 4.75 hours, not in even “day” amounts). Do you think this is
something you’d ever consider moving to, or are you fairly stuck on
the unit being days? "

We need to consider that.

There are some moment.js usage that is going to be deprecated, following is from test runs:

Basic leave request
Deprecation warning: moment construction falls back to js Date. This is discouraged and will be removed in upcoming major release. Please refer to moment/moment#1407 for more info.
Arguments: [object Object]
Error
at Function.createFromInputFallback (/home/travis/tom/node_modules/moment/moment.js:850:105)
at configFromString (/home/travis/tom/node_modules/moment/moment.js:970:32)
at configFromInput (/home/travis/tom/node_modules/moment/moment.js:1473:13)
at prepareConfig (/home/travis/tom/node_modules/moment/moment.js:1456:13)
at createFromConfig (/home/travis/tom/node_modules/moment/moment.js:1423:44)
at createLocalOrUTC (/home/travis/tom/node_modules/moment/moment.js:1505:16)
at local__createLocal (/home/travis/tom/node_modules/moment/moment.js:1509:16)
at utils_hooks__hooks (/home/travis/tom/node_modules/moment/moment.js:16:29)
at /home/travis/tom/lib/model/mixin/user/absence_aware.js:24:16
at Function..map..collect (/home/travis/tom/node_modules/underscore/underscore.js:172:24)
at _get_calendar_months_to_show (/home/travis/tom/lib/model/mixin/user/absence_aware.js:23:16)
at promise_calendar (/home/travis/tom/lib/model/mixin/user/absence_aware.js:42:36)
at router.get.base_date (/home/travis/tom/lib/route/calendar.js:107:14)
at Layer.handle as handle_request
at next (/home/travis/tom/node_modules/express/lib/router/route.js:100:13)
at Route.dispatch (/home/travis/tom/node_modules/express/lib/router/route.js:81:3)
at Layer.handle as handle_request
at /home/travis/tom/node_modules/express/lib/router/index.js:234:24
at Function.proto.process_params (/home/travis/tom/node_modules/express/lib/router/index.js:312:12)
at /home/travis/tom/node_modules/express/lib/router/index.js:228:12
at Function.match_layer (/home/travis/tom/node_modules/express/lib/router/index.js:295:3)
at next (/home/travis/tom/node_modules/express/lib/router/index.js:189:10)
at /home/travis/tom/node_modules/express/lib/router/index.js:191:16
at Function.match_layer (/home/travis/tom/node_modules/express/lib/router/index.js:295:3)

That page to have two sections:

• requests that are needed to be progressed
• requests that were decided by current user, for historical records

Fed up with troubles with Webfaction hosting.

Constant outages.

Move the website onto DO hosting.

Add bootstrap tool tips with brief field description next to field on registration page.

More important is to update the wording on the registration page to make it clear that it is registration of new COMPANY not just a user.

One team view page the column that represent current date should be visually distinguished.

Make My requests page mobile friendly.

Currently the application allocate the number of free time off days at the start of the year and employee is able to spend them at any point.

Few customers asked for feature when the allowance is accrued based on how far in the current year we are now.

"... We would need some notion of accrued time. Instead of having a fixed amount of time available at the beginning of the year, we officially accrue time based on an annual rate. If you had 12 vacation days per year, you would accrue 1 day per month (or more precisely, a certain amount per day). This is useful for 2 cases ..."

To implement this feature we do not need to do any DB changes other than adding new flag to the company level - that enables/disables it.

The business logic needs to be amended such a way that when requesting new leave system checks if user still within accrued number of available days.

That feature overlaps with some functionality discussed in #37

This is what of one of the customers wrote:

"In our case, time off is based on length of employment."

As it looks to me it is not complex to add feature of "time in company based allowance", that it with every year of being with a company employee gets extra day off until lets say 5.

That change would require few changes of DB structure:

• add flag that enables the feature on company level
• add the limit of how many extra days is possible to gain in such a way; again on the company level

The code that calculates the amount of available allowance needs to perform extra calculations: count of how many years the employee is with current company and based on that add extra days.

http://bluebirdjs.com/docs/new-in-bluebird-3.html

As one of customers requested ability to auth via LDAP, here are some notes where to start:

consider using https://www.npmjs.com/package/passport-ldapauth
for testing refere to http://stackoverflow.com/questions/7667197/is-there-any-free-ldap-server-with-data

Maybe just a way to export users from LDAP server?

express deprecated req.param(name): Use req.params, req.body, or req.query instead lib/route/login.js:94:23
express deprecated req.param(name): Use req.params, req.body, or req.query instead lib/route/login.js:101:22
express deprecated req.param(name): Use req.params, req.body, or req.query instead lib/route/login.js:106:26

Following section "Using Models In Code" in https://dzone.com/articles/sequelize-javascript-orm it is recommended to to use

app.set('models', require('./models'));

and then

var User = app.get('models').User;

in following places.

That will makes sure we open on DB connection.

That idea makes sense and we need to bring it into our project.

Got an email from customer:

in the adjustments, It won't let me enter half days adjustment?

Can you help?

When entering, for example, 1.5 in adjustment, it shows the message
"you must enter a valid value"

Consider adding tours with http://github.hubspot.com/shepherd/docs/welcome/

Tweak CSS to make My Calendar page being usable on mobiles.

When Adjustment is used total allowance is correct but remaining days are not

Use the sketch done in notebook as an example.

If current user has administrator's permissions, convert employee names on Team view page to be links to the Employee details page.

As customers suggested it would be better to use "[email protected]" email rather then my personal.

It involves setup new account on our hosting.

As our customer suggested:

...

One feature you may like to put on your list is the ability to prevent booking on certain days.

For example, towards the end of every May we run a huge exhibition, we don't allow staff to book holiday a week either side of this event. Would be great to allow a " holiday prohibited" date range.

...

Maybe it is not to block holidays completely but to highlight that at request submission and performing decision? So if some really necessary absences still to take place - it is possible to do so.

Write a test.

If that is set to false user does not have public holidays as days off.

As per customer request:

"Quick question from one of my team leaders, are we able to have the sick days displayed on the team view page with a different colour on the shading?"

In ideal world we need to make colour picker on the leave type setup page.

That is to be done later as needs more work.

Meanwhile make holidays that are not counted toward allocation be presented differently .