Coder Social home page Coder Social logo

Comments (10)

tisonkun avatar tisonkun commented on August 27, 2024 2

@YangKeao you have Maintain access to this repository already.

from pprof-rs.

Xuanwo avatar Xuanwo commented on August 27, 2024 1

Maybe when he is not that tired, he'd like to contact someone who knows the community rule of the tikv to help him solve the problem.

Based on my knowledge, only tikv committers can push tags directly.

Possible solutions include as follows:

  • Inviting one of the committers to take care of this project, maybe @andylokandy? They don't need to take part in the development, just need to push tags for release. I think it's not a big burden since pprof-rs is not heavy traffic.
  • Ping one of tikv's maintainers to give you more rights on this project. Because it doesn't make sense that you are the maintainer of pprof-rs but don't have permission to push tags.
  • Transfer this project out of tikv's umbrella if the tikv community doesn't have an interest in maintaining it.

Also, ping @tisonkun for more advice about the current situation.


Databend depends heavily on pprof-rs and I'm interested in maintaining pprof-rs, we can help maintain this project.

from pprof-rs.

skyzh avatar skyzh commented on August 27, 2024 1

Maybe we can integrate with a GitHub Action to automatically create release (and possibly upload to crates.io?)

Some examples: https://github.com/risinglightdb/sqllogictest-rs/blob/main/.github/workflows/release.yml

from pprof-rs.

YangKeao avatar YangKeao commented on August 27, 2024

The only maintainer of this project @YangKeao cannot push directly (so he cannot push tags). He rarely contributes to the tikv/tikv directly, and doesn't pay a lot attention to the community of tikv, so he doesn't know when/how/why it happened 😕 . He has tagged some commits a long time ago, but after some point in time, he cannot do it anymore.

Maybe when he is not that tired, he'd like to contact someone who knows the community rule of the tikv to help him solve the problem.

from pprof-rs.

Xuanwo avatar Xuanwo commented on August 27, 2024

I will raise this issue to tikv/community to get more ideas.

from pprof-rs.

Xuanwo avatar Xuanwo commented on August 27, 2024

Ping all maintainers of tikv for comments:

from pprof-rs.

YangKeao avatar YangKeao commented on August 27, 2024

@YangKeao you have Maintain access to this repository already.

Sorry for the misleading. As I just tried, I can push a tag (v0.9.1), but cannot push to master directly, is it expected?

To https://github.com/tikv/pprof-rs.git
 * [new tag]         v0.5.1 -> v0.5.1
 * [new tag]         v0.9.1 -> v0.9.1
 ! [rejected]        master -> master (fetch first)
error: failed to push some refs to 'https://github.com/tikv/pprof-rs.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

I think it's fine to push the tags 😆 . I'll tag some old releases to fix this problem.

Then the release process would be: @YangKeao submits a PR to upgrade the version, after it's merged, he will tag the commit and push the tag.

from pprof-rs.

Xuanwo avatar Xuanwo commented on August 27, 2024

As I just tried, I can push a tag (v0.9.1), but cannot push to master directly, is it expected?

I think it's expected. the master branch is protected and doesn't allow pushing directly.

Then the release process would be: @YangKeao submits a PR to upgrade the version, after it's merged, he will tag the commit and push the tag.

Looks good to me!

from pprof-rs.

YangKeao avatar YangKeao commented on August 27, 2024

Maybe we can integrate with a GitHub Action to automatically create release (and possibly upload to crates.io?)

Some examples: https://github.com/risinglightdb/sqllogictest-rs/blob/main/.github/workflows/release.yml

Automatically publishing on crates.io is pretty cool, maybe I could add a bot as the owner of this crate, and publish the crate through bot's token 🤔 .

from pprof-rs.

Xuanwo avatar Xuanwo commented on August 27, 2024

Closing for addressed, thanks @YangKeao again!

And also thanks advice from @tisonkun @skyzh.

from pprof-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.