tiffanylin21 / pe Goto Github PK

Users may make mistakes while typing and introduce an extra whitespace in the middle of names. TACH currently doesn't have a duplicate check for this and allows addition of both "Chloe Lee" and "Chloe L ee" even though a "person already in address book" warning should have been issued.

Command used:

1. add n/Chloe Lee e/[email protected] t/chloe201 g/jchloechloe tg/CS2101 G08

2. add n/Chloe L ee e/[email protected] t/chloe201 g/jchloechloe tg/CS2101 G08

Students might have a school email and personal email. Thus, more than 1 email should be allowed.
Command:

1. edit 1 e/[email protected]
2. e/[email protected]
   

Added tutorial group not shown on UI:
Command:
addtg 1 tg/CS2020S T03 tg/CS3040S T03 tg/CS3040S T03rc tg/CS3040S T03c tg/CS3040S T03D

TACH does not allow users to identify persons with the same name using an additional number at the back of a name.
The error message only stated that "Numbers are allowed, but they must strictly be at the end of the name." This does not tell me that I cannot put a number behind a name directly without whitespace.

Commands used:

1. add n/another1 e/[email protected] t/chloe201 g/jchloechloe tg/CS2101 G08

Cosmetic issue. Diagram or labelling in diagram is too small. Users have to zoom in to read details in the sequence diagram.

Tutorial group naming allows for multiple underscores which may be a typo by the user and should be disallowed since tutorial groups naming conventions for NUS don't typically have more than 1 underscores. Furthermore, if there are underscores, it is usually followed by a letter or number and thus underscores at the back should also be disallowed.

Extra whitespace in :Tutorial Group

This is inconsistent with other diagrams as below:

EDITED EDIT

There should be a check for duplicate emails since emails are unique.

Person 1, 2 and 3 share the same email even though that is a highly unlikely scenario in real life at NUS.

Diagrams in the developer guide not labelled as 'Class diagram' but was referred to as "the diagram" etc.

This is inconsistent as the team's sequence diagrams have been labelled as below:

Error message implies that index can be up to 2,147,483,647 but index also cannot be more than number of students in the list. Users are only notified of this if they then tried an index bigger than the number of students.
Error message should have warned user that index cannot be more than number of users rather than 2,147,483,647.

Commands used:

delete 0 :

Rather than `They should appear as the 3rd...", since it is only referring to 1 person, it should be 'Carl Sagen should appear...' or 'he should appear...' or 'The student should appear...'

There should be an explanation of why the lifeline extends beyond the 'X' in the sequence diagram. This is so for all sequence diargams.

TACH's name check is not case-insensitive. Users are not warned when adding "Chloe Lee" and "chloe Lee" even though both should refer to the same person.

Commands used:

1. add n/Chloe Lee e/[email protected] t/chloe201 g/jchloechloe tg/CS2101 G08

2. add n/chloe Lee e/[email protected] t/chloe201 g/jchloechloe tg/CS2101 G08

Field name TUTORIAL_GROUP in 'Command Summary different from field name `TUTORIAL_GROUPS] in 'Editing a Student'

1. editing a student

2. command summary
   

Missing word here, should be '...needs to be deleted".

Inconsistent display of Telegram handle. Bernice has no '@' while Charlotte has an '@' at the beginning.

Screenshot taken from pre-set data in TACH: