[d2s] [Unofficial device] [Question] Building KernelSU into LOS kernel results in non-functional su about kernelsu

[tiann]

You should use the manual way to integrate, the compile error is because the source change and you need to make some changes to the patch. You can follow the instructions and re-integrate it again, it should work well.

[Unb0rn]

@tiann Thank you for a quick response and sorry for bothering again) I did as you told me and it's mostly working now - su, modules, only profiles don't stick, but I think I'll try to figure it out in the discussions section myself.

The only question I have left - I discovered several kernels in Unofficial device support: Samsung a50, Exynos9820, Samsung Tab S7 - just a few to mention - all of which use the same approach - they use the reference manual patch for adding the hooks, however, all of them omit all the conditionals for ksu_handle_execveat, ksu_handle_vfs_read and ksu_handle_input_handle_event. So for example the call

if (unlikely(ksu_vfs_read_hook))
	ksu_handle_vfs_read(&file, &buf, &count, &pos);

becomes just
ksu_handle_vfs_read(&file, &buf, &count, &pos);

I'm not sure if I understand what this flag does: ksu_vfs_read_hook so I have to ask - Speaking security- and performance-wise is it okay to use such an approach?
Also added the same hooks to my repo
Thanks again!