Coder Social home page Coder Social logo

Comments (9)

jenswet avatar jenswet commented on June 22, 2024 14

@tiangolo Can you trigger a new build please?

from uvicorn-gunicorn-fastapi-docker.

rozacek avatar rozacek commented on June 22, 2024 5

I noticed the same problem.
Currently fastapi version in images is: 0.55.1 what is very confusing when goes on working with root_path feature: https://fastapi.tiangolo.com/advanced/behind-a-proxy/ as it's supported since 0.56.0!!! I lost a day due to that fact :(

from uvicorn-gunicorn-fastapi-docker.

JayPalm avatar JayPalm commented on June 22, 2024 1

the discussion was about new runs of the image builds, not Python versions.

Yup, egg on my face. Was distracted as to the subject mater I guess. Cheers.

from uvicorn-gunicorn-fastapi-docker.

graue70 avatar graue70 commented on June 22, 2024

In the meantime, you can use this:

FROM tiangolo/uvicorn-gunicorn:python3.8

RUN PIP_NO_CACHE_DIR=1 \
    PIP_DISABLE_PIP_VERSION_CHECK=1 \
    pip install fastapi

# ...

COPY ./app /app

It is inspired by the original Dockerfile. Of course, it only works for uvicorn-gunicorn tags which are supported (particularly, it doesn't currently work for python 3.9 or for any python version with alpine higher than 3.10).

from uvicorn-gunicorn-fastapi-docker.

Mazyod avatar Mazyod commented on June 22, 2024

Starlette samesite keyword argument on set_cookie is also missing due to outdated images. 🙇‍♂️

from uvicorn-gunicorn-fastapi-docker.

tiangolo avatar tiangolo commented on June 22, 2024

Thanks for the discussion here everyone! I think this was triggered/handled a while ago, right?

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

from uvicorn-gunicorn-fastapi-docker.

JayPalm avatar JayPalm commented on June 22, 2024

Thanks for the discussion here everyone! I think this was triggered/handled a while ago, right?

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

@tiangolo, is this an automated reply?

Don't think so. Appears that the Python3.9 release is still the latest image available, from over a year ago, but I'm no longer relying on this image, in favor of my own. I see there are recent commits to uvicorn-gunicorn repo however, including a 3.10 branch.

from uvicorn-gunicorn-fastapi-docker.

tiangolo avatar tiangolo commented on June 22, 2024

No, it's not an automated reply, the discussion was about new runs of the image builds, not Python versions.

And yep, indeed, you should probably rely on your own image, you probably don't need this one as explained in the README: https://github.com/tiangolo/uvicorn-gunicorn-fastapi-docker#-warning-you-probably-dont-need-this-docker-image

I'm glad you found a solution for your use cases. 👍

from uvicorn-gunicorn-fastapi-docker.

github-actions avatar github-actions commented on June 22, 2024

Assuming the original issue was solved, it will be automatically closed now. But feel free to add more comments or create new issues.

from uvicorn-gunicorn-fastapi-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.